[OpenSIPS-Devel] [OpenSIPS/opensips] 7da663: dialog: fix unset_dlg_profile() linkers deletion

[Razvan Crainea]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7da66308ef9dffefe39e8e3d8311ab4d59e59fe3
      https://github.com/OpenSIPS/opensips/commit/7da66308ef9dffefe39e8e3d8311ab4d59e59fe3
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: fix unset_dlg_profile() linkers deletion

This commit fixes the following bugs introduced in commit 00cddf7:
1. when it was called, it was removing all the linkers of a dialog
2. it was not removing the actual linker it was called for, causing
constant increase in size for that specific profile (and leak)
3. when temporary copying the profiles list, the values were not copied,
thus they might have dissapeared when the actual cleanup was done.

Many thanks to Jonathan Hulme for reporting the issue and providing
testing framework for detecting the bug and testing the fix!

(cherry picked from commit 1f350f4bf88d1fbb67bf30d17fd74231417a5fa2)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.