[OpenSIPS-Devel] [OpenSIPS/opensips] c01855: Fix dialog unref for local BYEs.

[Bogdan-Andrei Iancu]

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c0185546700b6adb89b13f77801f5dc72eea4b24
      https://github.com/OpenSIPS/opensips/commit/c0185546700b6adb89b13f77801f5dc72eea4b24
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix dialog unref for local BYEs.

Instead of unref-ing the dialog when a final reply is received for the local BYE, better wait until the BYE transaction is destroyed. IF not, we will end up with a dangling dailog pointer in the BYE transaction.
Fix for #1330 where a local BYE retransmission in combination with TH ends up acessing the dangling dialog pointer.
Many thanks to Nick Altmann for the support in investigating this issue.

(cherry picked from commit ec52613da12d43299edf0dab26ae80e5d2153854)
(cherry picked from commit 2d02ffba4890457ee2f3e0a49b59bea2c7872c7f)


  Commit: c22f6ab32455040ec7a366cde4d46be42397dfab
      https://github.com/OpenSIPS/opensips/commit/c22f6ab32455040ec7a366cde4d46be42397dfab
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix CRIT logs back to DBG.

(cherry picked from commit ee7db82ae39eb13fa3675dd05112731af36dfbfc)
(cherry picked from commit dd8fc985ac0c52a3b01055d2b82e6f51ce847b82)


Compare: https://github.com/OpenSIPS/opensips/compare/439990c22e37...c22f6ab32455