[OpenSIPS-Devel] [OpenSIPS/opensips] ec5261: Fix dialog unref for local BYEs.

Bogdan-Andrei Iancu bogdan at opensips.org
Mon Apr 16 10:36:20 EDT 2018


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ec52613da12d43299edf0dab26ae80e5d2153854
      https://github.com/OpenSIPS/opensips/commit/ec52613da12d43299edf0dab26ae80e5d2153854
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix dialog unref for local BYEs.

Instead of unref-ing the dialog when a final reply is received for the local BYE, better wait until the BYE transaction is destroyed. IF not, we will end up with a dangling dailog pointer in the BYE transaction.
Fix for #1330 where a local BYE retransmission in combination with TH ends up acessing the dangling dialog pointer.
Many thanks to Nick Altmann for the support in investigating this issue.




More information about the Devel mailing list