[OpenSIPS-Devel] [OpenSIPS/opensips] b18a61: dialog: fix a runtime bug with DLGCB_LOADED callba...

rvlad-patrascu vladp at opensips.org
Mon Oct 16 11:15:35 EDT 2017


  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b18a61ef3ae07c70cf4dd8b13d69ece9f6c6f3f3
      https://github.com/OpenSIPS/opensips/commit/b18a61ef3ae07c70cf4dd8b13d69ece9f6c6f3f3
  Author: rvlad-patrascu <vladp at opensips.org>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_cb.c

  Log Message:
  -----------
  dialog: fix a runtime bug with DLGCB_LOADED callbacks

Relying on the fact that all modules that register dialog callbacks are initialised
after the dialog module (thanks to module dependencies), we can run all DLGCB_LOADED
callbacks at registration time and also keep them in a list for calling them later
(i.e reloading from database via MI cmd or receiving replicated dialog).

This fixes a series of bugs where the DLGCB_LOADED callback is not run during, e.g.
"dlg_db_sync" MI command or received replicated dialogs which do not have their
callbacks installed or run.

(cherry picked from commit 8c8f27f6091289061f6aaf0d3c85ccd27db80a0d)


  Commit: 29d764d5224b881db97c1c256fcffac4842129dc
      https://github.com/OpenSIPS/opensips/commit/29d764d5224b881db97c1c256fcffac4842129dc
  Author: rvlad-patrascu <vladp at opensips.org>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: also share module flags when replicating dialogs

(cherry picked from commit ad35e7cedc44efd90c58f26a853585ece5883bac)

Conflicts:
	modules/dialog/dlg_replication.c


Compare: https://github.com/OpenSIPS/opensips/compare/caf912d64626...29d764d5224b


More information about the Devel mailing list