[OpenSIPS-Devel] [OpenSIPS/opensips] 77df0c: usrloc: Fix locking for contact_id-based deletion

[Liviu Chircu]

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 77df0c04a36b5b06a46797e3c73385e7dec737d9
      https://github.com/OpenSIPS/opensips/commit/77df0c04a36b5b06a46797e3c73385e7dec737d9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M modules/usrloc/dlist.c

  Log Message:
  -----------
  usrloc: Fix locking for contact_id-based deletion

The delete_ucontact_from_id(), get_ucontact_from_id() pair of functions
were masking possible code execution paths which would lead to unsafe memory
access. This, in turn, would cause the ping_checker_timer() job of nathelper to
occasionally crash and burn.

Reported by solo at astercc.org.

(cherry picked from commit 18a93c89aa1c32498689a6f6dd09911272c18896)


  Commit: 0fcf5710b6e59bdeff9a634155b2f04380d98046
      https://github.com/OpenSIPS/opensips/commit/0fcf5710b6e59bdeff9a634155b2f04380d98046
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M modules/usrloc/urecord.c

  Log Message:
  -----------
  usrloc: Fix bad logical condition

Reported by Răzvan Crainea.

(cherry picked from commit a644f1b370d61e60b2f4de20c9728564d8d8a06d)


Compare: https://github.com/OpenSIPS/opensips/compare/10849522cfcd...0fcf5710b6e5