[OpenSIPS-Devel] [OpenSIPS/opensips] 63c1a8: clang: Add "-Wall" flag

Liviu Chircu liviu at opensips.org
Wed Nov 15 10:11:23 EST 2017 

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 63c1a844b702d6f86db1ee9e59262b7e01bcb19a
      https://github.com/OpenSIPS/opensips/commit/63c1a844b702d6f86db1ee9e59262b7e01bcb19a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-13 (Mon, 13 Nov 2017)

  Changed paths:
    M Makefile.defs

  Log Message:
  -----------
  clang: Add "-Wall" flag


  Commit: 7585f88cca82e915fc6a5407dead04f0cca01013
      https://github.com/OpenSIPS/opensips/commit/7585f88cca82e915fc6a5407dead04f0cca01013
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-13 (Mon, 13 Nov 2017)

  Changed paths:
    M mem/f_malloc.c
    M mem/hp_malloc.c
    M mem/module_info.c
    M mem/module_info.h
    M mem/q_malloc.c

  Log Message:
  -----------
  mod stats: Fix unhandled corner-case

Do not crash on NULL pointer input.


  Commit: d4967201bf4243646eef0a92be1c37dff0aba29d
      https://github.com/OpenSIPS/opensips/commit/d4967201bf4243646eef0a92be1c37dff0aba29d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M modules/usrloc/udomain.c

  Log Message:
  -----------
  usrloc API: Make get_urecord() more robust

Zeroize the output pointer if record is not found.


  Commit: 18a93c89aa1c32498689a6f6dd09911272c18896
      https://github.com/OpenSIPS/opensips/commit/18a93c89aa1c32498689a6f6dd09911272c18896
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-14 (Tue, 14 Nov 2017)

  Changed paths:
    M modules/usrloc/dlist.c

  Log Message:
  -----------
  usrloc: Fix locking for contact_id-based deletion

The delete_ucontact_from_id(), get_ucontact_from_id() pair of functions
were masking possible code execution paths which would lead to unsafe memory
access. This, in turn, would cause the ping_checker_timer() job of nathelper to
occasionally crash and burn.

Reported by solo at astercc.org.


  Commit: a5d633924fc78cd4d9999a727ab529cb1bf50405
      https://github.com/OpenSIPS/opensips/commit/a5d633924fc78cd4d9999a727ab529cb1bf50405
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M ut.h

  Log Message:
  -----------
  Fix int2str() function signature

Although implemented to be able to print 64-bit integers, int2str()
downcasted all of its parameters to an "unsigned long" type, thus
breaking behavior on 32-bit architectures.


  Commit: e9be01680557a030c5fd6346299f5db663467018
      https://github.com/OpenSIPS/opensips/commit/e9be01680557a030c5fd6346299f5db663467018
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M ut.h

  Log Message:
  -----------
  Add str2int64() parsing function


  Commit: 15a5067b2d493c273842b723199d42c695a1b93f
      https://github.com/OpenSIPS/opensips/commit/15a5067b2d493c273842b723199d42c695a1b93f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/usrloc/udomain.h
    M modules/usrloc/urecord.c
    M modules/usrloc/urecord.h
    M modules/usrloc/usrloc.c
    M modules/usrloc/usrloc.h

  Log Message:
  -----------
  usrloc: Add some useful API functions

    * get_ucontact_from_id() - fetch both ct and rec from an id
    * next_contact_id() - fetch and advance the current ct counter


  Commit: 7d4894943ad522406d1f2cb9231821c91f423562
      https://github.com/OpenSIPS/opensips/commit/7d4894943ad522406d1f2cb9231821c91f423562
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/usrloc/urecord.c

  Log Message:
  -----------
  usrloc: Allow forced IDs during contact inserts


  Commit: ad274fad9a6fd072737d45230a0c297d0e4b9329
      https://github.com/OpenSIPS/opensips/commit/ad274fad9a6fd072737d45230a0c297d0e4b9329
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/usrloc/udomain.c
    M modules/usrloc/urecord.c
    M modules/usrloc/urecord.h

  Log Message:
  -----------
  usrloc: Add urecord reference counting mechanism

This mechanism is required by the mid-registrar, which needs to
"reserve" contact IDs while the main registrar decides upon them.
This means that a blank urecord structure must be kept alive during
this process.

By reference counting the blank urecord structures, we prevent them
from being cleared by the timer before the outgoing registrations
get a chance to receive a reply.


  Commit: 8c46ab3cad07029a1e78fdb1d57300247c00c4eb
      https://github.com/OpenSIPS/opensips/commit/8c46ab3cad07029a1e78fdb1d57300247c00c4eb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix possible crash in mirror mode


  Commit: 7e190a8b1cdcdfe66afe9eea4b0be4c75f275a89
      https://github.com/OpenSIPS/opensips/commit/7e190a8b1cdcdfe66afe9eea4b0be4c75f275a89
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/mid_registrar/lookup.c
    M modules/mid_registrar/lookup.h
    M modules/mid_registrar/mid_registrar.c
    M modules/mid_registrar/mid_registrar.h
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix NAT issues in "contact" insertion mode

This patch completely reworks the saving/matching logic with regards
to the SIP contacts generated by the mid-registrar. It is only relevant
to working modes "0" (mirror) and "1" (contact throttling).

The former logic (encoding the requests's Contact as a URI parameter
of the outgoing contact) was somewhat stateless, as it would forward
requests to the mid-registrar's contacts directly to their actual Contact
URIs (UA side). When NAT comes into play, this no longer works well.

Fortunately, the user location already handles this problem. Thus, we
change the mid-registrar to advertise contact IDs instead of the device's
contact. As requests arrive for the contact IDs, we are easily able to
look up their corresponding user location AoR, contact, along with any
other useful information for NAT traversal.


  Commit: 016da2f7f31b764da5dcce1d4189b8f9ef77b5cb
      https://github.com/OpenSIPS/opensips/commit/016da2f7f31b764da5dcce1d4189b8f9ef77b5cb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M modules/mid_registrar/mid_registrar.h
    M modules/mid_registrar/save.c
    M modules/mid_registrar/ulcb.c

  Log Message:
  -----------
  mid_registrar: Fix CSeq handling for De-REGISTERs

Keep track of outgoing CSeq values and use this value during
self-generated de-registrations, rather than using the tm's built-in
default CSeq value of "13".


  Commit: 48cb7a78970b6ffebbcd93ef17f5d83d24cf5a87
      https://github.com/OpenSIPS/opensips/commit/48cb7a78970b6ffebbcd93ef17f5d83d24cf5a87
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M Makefile.defs
    M mem/f_malloc.c
    M mem/hp_malloc.c
    M mem/module_info.c
    M mem/module_info.h
    M mem/q_malloc.c
    M modules/mid_registrar/lookup.c
    M modules/mid_registrar/lookup.h
    M modules/mid_registrar/mid_registrar.c
    M modules/mid_registrar/mid_registrar.h
    M modules/mid_registrar/save.c
    M modules/mid_registrar/ulcb.c
    M modules/usrloc/dlist.c
    M modules/usrloc/udomain.c
    M modules/usrloc/udomain.h
    M modules/usrloc/urecord.c
    M modules/usrloc/urecord.h
    M modules/usrloc/usrloc.c
    M modules/usrloc/usrloc.h
    M ut.h

  Log Message:
  -----------
  Merge branch 'bugfix/mid-registrar-store-contacts-as-aors'


Compare: https://github.com/OpenSIPS/opensips/compare/d67fbb980942...48cb7a78970b

More information about the Devel mailing list