[OpenSIPS-Devel] [OpenSIPS/opensips] cc63f2: HP_MALLOC: Fix a startup ordering issue

Liviu Chircu liviu at opensips.org
Thu Mar 30 06:53:55 EDT 2017


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cc63f2de47f59bd01b7663413a825323eb100e92
      https://github.com/OpenSIPS/opensips/commit/cc63f2de47f59bd01b7663413a825323eb100e92
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-03-29 (Wed, 29 Mar 2017)

  Changed paths:
    M main.c
    M mem/hp_malloc.c
    M mem/shm_mem.c
    M mem/shm_mem.h

  Log Message:
  -----------
  HP_MALLOC: Fix a startup ordering issue

Memory warming would never be run at all, due to the following
dependency (issue introduced by 4089d44ca):
  mem warming         -> "mem_warming_enabled" -> yyparse()
  (in init_shm_mallocs())

But init_shm_mallocs() runs _before_ yyparse()!

This patch moves the mem warming code after yyparse().


  Commit: 009691c6c7672927f68cfb8a0340166167a04107
      https://github.com/OpenSIPS/opensips/commit/009691c6c7672927f68cfb8a0340166167a04107
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-03-30 (Thu, 30 Mar 2017)

  Changed paths:
    M socket_info.c
    M socket_info.h

  Log Message:
  -----------
  core "net:" statistics: Fix an integer signedness bug

Due to runaway usage of bitwise shifting, the byte matching code would fail to
work for interfaces having low order bytes with greater values than 128
(e.g. udp:31.32.33.147:5060). Consequently, all "net:" statistics for them
would show up as zeroes.

Thanks to Bogdan and Răzvan for discovering and troubleshooting


Compare: https://github.com/OpenSIPS/opensips/compare/e5a2a4cebf4c...009691c6c767


More information about the Devel mailing list