[OpenSIPS-Devel] [OpenSIPS/opensips] 382f56: Added extra code for sanity checks over reactor da...

[Bogdan-Andrei Iancu]

Hi Ovidiu,

Strange, my compiler did not complained about that, still there are some 
logical cases where you end up printing an un-init value for "already".

Fixes are available on all versions.

Many thanks,

Bogdan-Andrei Iancu
   OpenSIPS Founder and Developer
   http://www.opensips-solutions.com

OpenSIPS Bootcamp 2017, Houston, US
   http://opensips.org/training/OpenSIPS_Bootcamp_2017.html

On 07/03/2017 05:04 PM, Ovidiu Sas wrote:
> This set of commits seems to generate some errors all over the code:
> Compiling async.c
> In file included from mem/shm_mem.h:53:0,
>                   from async.c:26:
> io_wait.h: In function ‘io_watch_add.constprop.6’:
> mem/../dprint.h:335:11: warning: ‘already’ may be used uninitialized
> in this function [-Wmaybe-uninitialized]
>       dprint( _prefix LOG_PREFIX _fmt, dp_time(), \
>             ^
> In file included from reactor_defs.h:40:0,
>                   from async.c:28:
> io_wait.h:381:6: note: ‘already’ was declared here
>    int already;
>        ^
>
> -ovidiu
>
> On Mon, Jul 3, 2017 at 9:32 AM, Bogdan-Andrei Iancu <bogdan at opensips.org> wrote:
>>    Branch: refs/heads/2.3
>>    Home:   https://github.com/OpenSIPS/opensips
>>    Commit: 382f567cf35affd1b04a838de1b260f720222d61
>>        https://github.com/OpenSIPS/opensips/commit/382f567cf35affd1b04a838de1b260f720222d61
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait.h
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Added extra code for sanity checks over reactor data
>>
>> (cherry picked from commit ab26d05599074e8ef4a5ba7f68e60c739be7cbfc)
>>
>>
>>    Commit: e05db1806cdb8fb0040672f0f12697922977dd9b
>>        https://github.com/OpenSIPS/opensips/commit/e05db1806cdb8fb0040672f0f12697922977dd9b
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait.h
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Fix prev commit - data may be null for valid fd maps (like timer jobs)
>>
>> (cherry picked from commit b90094c46bb8dadc3f6f13be6c394c6b7208190e)
>>
>>
>>    Commit: 2035f4049f273f90a935239e8a85d54577d867aa
>>        https://github.com/OpenSIPS/opensips/commit/2035f4049f273f90a935239e8a85d54577d867aa
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait.h
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Fix for prev+1 commit - fd=0 should be consider unset (as -1)
>>
>> (cherry picked from commit 0dfbad3861e6fb066db3a4aea4e78f17ab0b27f5)
>>
>>
>>    Commit: 84a53b8bd9b11990741399da9d3e024fc66db39d
>>        https://github.com/OpenSIPS/opensips/commit/84a53b8bd9b11990741399da9d3e024fc66db39d
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait.h
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Flag reset fixed; print flags as hexa
>>
>> (cherry picked from commit 34d98d82dc7cff162782b57af8e8f04e6719109c)
>>
>>
>>    Commit: d4f99f78640e4eb84d70ff7737d7ed9739ad5172
>>        https://github.com/OpenSIPS/opensips/commit/d4f99f78640e4eb84d70ff7737d7ed9739ad5172
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Triggered fds with no fd_map are reported and removed from epoll
>>
>> If epoll triggers on a fd that has a cleared (removed) fd_map, remove it from epoll.
>>
>> (cherry picked from commit ade9c93d807abb97ababa0033589b46f70c040da)
>>
>>
>>    Commit: e38e6daa17f989d0704df614718591e0aa375fdb
>>        https://github.com/OpenSIPS/opensips/commit/e38e6daa17f989d0704df614718591e0aa375fdb
>>    Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
>>    Date:   2017-07-03 (Mon, 03 Jul 2017)
>>
>>    Changed paths:
>>      M io_wait_loop.h
>>
>>    Log Message:
>>    -----------
>>    Downgrade severity and extra loging on epoll self healing
>>
>> (cherry picked from commit b60780c502ae3b7b9f54f2047da04cb95d915e5b)
>>
>>
>> Compare: https://github.com/OpenSIPS/opensips/compare/b06f4fb4e50c...e38e6daa17f9
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>
>
>