[OpenSIPS-Devel] [OpenSIPS/opensips] 0067a7: Fix several binary interface bugs

Liviu Chircu liviu at opensips.org
Thu Apr 13 11:05:36 EDT 2017


  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0067a77a1659ea59068203ac23c9d93acf81d6fb
      https://github.com/OpenSIPS/opensips/commit/0067a77a1659ea59068203ac23c9d93acf81d6fb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-04-13 (Thu, 13 Apr 2017)

  Changed paths:
    M bin_interface.c

  Log Message:
  -----------
  Fix several binary interface bugs

    * badly handled empty str pushes
    * buggy str pop operations
    * missing safety check
    * addition instead of subtraction bug :|
    * bad limit check
    * fix guaranteed crash if out of pkg mem

Fixes #1084

(cherry picked from commit 3d2abb23ce0063150e2a945d876bec03b079b6cf)


  Commit: a8f20907b122b1bff0ac21bf751683daef3e31ca
      https://github.com/OpenSIPS/opensips/commit/a8f20907b122b1bff0ac21bf751683daef3e31ca
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-04-13 (Thu, 13 Apr 2017)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Avoid potential crash when debugging ("log_level = 4")

(cherry picked from commit 8ebca4bfbebb49f5598bb9079b24368c85afb84e)


  Commit: 8851cef1b1654f3c958fee64fa3e86eda52b3722
      https://github.com/OpenSIPS/opensips/commit/8851cef1b1654f3c958fee64fa3e86eda52b3722
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2017-04-13 (Thu, 13 Apr 2017)

  Changed paths:
    M bin_interface.c
    M bin_interface.h

  Log Message:
  -----------
  binary interface: Improve coding style

    * fix missing "\n" in log messages
    * improve readability of buffer safety checks
    * bin_extend(), rather than bin_realloc()
    * fix some line lengths
    * fix typos

(cherry picked from commit 06bc4ba4d560606ddd8299754e03ef1b3c1f4007)


Compare: https://github.com/OpenSIPS/opensips/compare/e00b03a9a1b3...8851cef1b165


More information about the Devel mailing list