[OpenSIPS-Devel] [OpenSIPS/opensips] 4ec793: Added content-aware body (multi-part) changing.

Wed Nov 9 09:39:46 CET 2016

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4ec793600d60be4386758afa763da5205040fd79
      https://github.com/OpenSIPS/opensips/commit/4ec793600d60be4386758afa763da5205040fd79
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M msg_translator.c
    M msg_translator.h
    M parser/parse_body.c
    M parser/parse_body.h

  Log Message:
  -----------
  Added content-aware body (multi-part) changing.

The new code allows parsing and modification of the body via the "body parts" list - parts can be modified (with function or lumps), can be deleted and new ones can be added. Any type of modification (and any of them) is allowed.
The body is completely rebuild based on the resulting list of body parts.
Also the new code supports transparent transitions from no body to body, single part body to multi-part body or the other way around - with automatic update of the Content-Type and Content-Len headers, of course.

  Commit: 8a3f3144f2a2ba8a3d5820e49c0c82d364cb70b9
      https://github.com/OpenSIPS/opensips/commit/8a3f3144f2a2ba8a3d5820e49c0c82d364cb70b9
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M msg_translator.c

  Log Message:
  -----------
  Fix calculating len for multi-2-multi with dump function

  Commit: efedc90cea45beb42951c5fb933c06757f813976
      https://github.com/OpenSIPS/opensips/commit/efedc90cea45beb42951c5fb933c06757f813976
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: add \n to log

Reported by Hamid on the lists

  Commit: 2e7187060fe685cfbe12a8613445def32f094c43
      https://github.com/OpenSIPS/opensips/commit/2e7187060fe685cfbe12a8613445def32f094c43
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M msg_translator.c

  Log Message:
  -----------
  msg: fix confusing check of unsigned < 0

  Commit: 11713fef6cc8decdb4114a4509ab9a95eb7f4de4
      https://github.com/OpenSIPS/opensips/commit/11713fef6cc8decdb4114a4509ab9a95eb7f4de4
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M msg_translator.c

  Log Message:
  -----------
  Fixed proper usage of dump_f prototype.

The function returns only true/false, not the len of the buffer.

  Commit: b6c4d3e9e8311920eec7809cced7e18d5c233e18
      https://github.com/OpenSIPS/opensips/commit/b6c4d3e9e8311920eec7809cced7e18d5c233e18
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M parser/parse_body.h

  Log Message:
  -----------
  Improve the docs on the body_part structure fields.

  Commit: cba64bc055163f4e883a6e5aebdca845fd000deb
      https://github.com/OpenSIPS/opensips/commit/cba64bc055163f4e883a6e5aebdca845fd000deb
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/rtpproxy_admin.xml

  Log Message:
  -----------
  rtpproxy: doc warn about asym processing in bridging mode

  Commit: 15b12f59cc2cbfdab1b37558a855a6d04345547d
      https://github.com/OpenSIPS/opensips/commit/15b12f59cc2cbfdab1b37558a855a6d04345547d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-28 (Fri, 28 Oct 2016)

  Changed paths:
    M modules/emergency/sip_emergency.c
    M modules/nathelper/nathelper.c
    M modules/rtpengine/rtpengine.c
    M modules/rtpengine/rtpengine_funcs.c
    M modules/rtpproxy/rtpproxy.c
    M parser/parse_body.h
    M parser/sdp/sdp.c

  Log Message:
  -----------
  When iterating through the parts for doing changes, avoid the new or deleted parts.

  Commit: 4057a5fd67844ccbe478d65a1f0181118c8dcd1d
      https://github.com/OpenSIPS/opensips/commit/4057a5fd67844ccbe478d65a1f0181118c8dcd1d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-28 (Fri, 28 Oct 2016)

  Changed paths:
    M parser/parse_body.c

  Log Message:
  -----------
  Fixes related to adding new body part.

  Commit: 60cb8514f20daeb7708f79b6cac20a3adc736020
      https://github.com/OpenSIPS/opensips/commit/60cb8514f20daeb7708f79b6cac20a3adc736020
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-29 (Sat, 29 Oct 2016)

  Changed paths:
    M parser/parse_body.c

  Log Message:
  -----------
  Fixed populated mime_s for single part

  Commit: 79941119576e88d67865bcbeec19d133008b378a
      https://github.com/OpenSIPS/opensips/commit/79941119576e88d67865bcbeec19d133008b378a
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-29 (Sat, 29 Oct 2016)

  Changed paths:
    M msg_translator.c

  Log Message:
  -----------
  Fixed body reassamble - some part separators were missing

  Commit: 8e8d0c974031a009040cfed000e7efd1cdbd27f1
      https://github.com/OpenSIPS/opensips/commit/8e8d0c974031a009040cfed000e7efd1cdbd27f1
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-10-29 (Sat, 29 Oct 2016)

  Changed paths:
    M modules/sipmsgops/README
    M modules/sipmsgops/doc/sipmsgops_admin.xml
    M modules/sipmsgops/sipmsgops.c

  Log Message:
  -----------
  Refactored for multi-part support.

has_body() -> has_body_part([mime])
filter_body() + strip_body() -> remove_body_part([mime,[revert]])
added add_body_part(body,mime) to append a new body part

  Commit: 098ddfb129a035749241e73e4a2b608963ce46a9
      https://github.com/OpenSIPS/opensips/commit/098ddfb129a035749241e73e4a2b608963ce46a9
  Author: ionutrazvanionita <ionutionita at opensips.org>
  Date:   2016-11-01 (Tue, 01 Nov 2016)

  Changed paths:
    M modules/drouting/routing.c

  Log Message:
  -----------
  [dr] remove unnecessary print

  Commit: 81498e4ce0e7e2928d229b69da0c440660c97544
      https://github.com/OpenSIPS/opensips/commit/81498e4ce0e7e2928d229b69da0c440660c97544
  Author: ionutrazvanionita <ionutionita at opensips.org>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M modules/compression/compression.c

  Log Message:
  -----------
  [compression] fix bad header section length calculation for mc_compact

  Commit: 1a42b8fa8c69e8f29b39c78788d45a364186aa54
      https://github.com/OpenSIPS/opensips/commit/1a42b8fa8c69e8f29b39c78788d45a364186aa54
  Author: ionutrazvanionita <ionutionita at opensips.org>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M modules/acc/acc_vars.c

  Log Message:
  -----------
  [acc] fix bad negative index calculation for acc_leg variable

  Commit: 00be97f151d254af281c4f05611c1905f51fbcde
      https://github.com/OpenSIPS/opensips/commit/00be97f151d254af281c4f05611c1905f51fbcde
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix incorrect replicated dialog ids

Also improve code readability with regards to dialog id handling

Issue reported by Dawid Mielnik

  Commit: f4ac7aa14a78833810dc21c435c1a8c84a92ec10
      https://github.com/OpenSIPS/opensips/commit/f4ac7aa14a78833810dc21c435c1a8c84a92ec10
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M net/proto_udp/proto_udp.c

  Log Message:
  -----------
  udp: print IP:port when there is a sendto error

This can ease debugging in case of errors

  Commit: 2efc77d0d8eb905f3ed92cfb5136fa5bc8f0c33a
      https://github.com/OpenSIPS/opensips/commit/2efc77d0d8eb905f3ed92cfb5136fa5bc8f0c33a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M modules/fraud_detection/fraud_detection.c

  Log Message:
  -----------
  fraud_detection: Fix possible startup crash

Race condition between drouting startup and check_fraud()

Credits to Jim DeVito for helping with troubleshooting

  Commit: 04f488025e647989e1787c84abd5d5e374cfc563
      https://github.com/OpenSIPS/opensips/commit/04f488025e647989e1787c84abd5d5e374cfc563
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M modules/dispatcher/dispatch.c

  Log Message:
  -----------
  Fix bogus printing of socket pointer.

Do not print the '\0', as it will break the logs formating.

(cherry picked from commit 5acb935e06152b167469e7a31e917e7974f1c7e5)
(cherry picked from commit 91de722ec2a3f54a157bd7fafb482e3a99699fbe)

  Commit: 1d5d8e11db7388a0e989c7a37cef56c076cb1a0c
      https://github.com/OpenSIPS/opensips/commit/1d5d8e11db7388a0e989c7a37cef56c076cb1a0c
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M modules/dispatcher/dispatch.c
    M modules/dispatcher/dispatch.h
    M modules/dispatcher/dispatcher.c

  Log Message:
  -----------
  Fixed bogus passing of socket pointer as printed value in a a buffer.

(cherry picked from commit 85c3bc5ed74481b1ad736ae6b860082c99fbba9a)
(cherry picked from commit eafe60897e510697a5599c113923dca4cc78fed1)

  Commit: c89bc1ceeb14c7a31888a179d2bc5431ad638f29
      https://github.com/OpenSIPS/opensips/commit/c89bc1ceeb14c7a31888a179d2bc5431ad638f29
  Author: ionutrazvanionita <ionutionita at opensips.org>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M modules/proto_hep/proto_hep.c

  Log Message:
  -----------
  [proto_hep] check if hep context was allocated before freeing

This closes #986

  Commit: c221eb3db06c7dae3375defa79ce77e1983ebc87
      https://github.com/OpenSIPS/opensips/commit/c221eb3db06c7dae3375defa79ce77e1983ebc87
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M net/trans.c

  Log Message:
  -----------
  net: do not warn about listener not used and not found

  Commit: f81e9bf5f0e4a75d6279b8c9e2f1397538e6e953
      https://github.com/OpenSIPS/opensips/commit/f81e9bf5f0e4a75d6279b8c9e2f1397538e6e953
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M modules/dns_cache/dns_cache.c

  Log Message:
  -----------
  Fixed bogus test on pointers.

This may lead to invalid len to be returned.

  Commit: f1d8209e826de159a95a2869d97d5dd4c446fa08
      https://github.com/OpenSIPS/opensips/commit/f1d8209e826de159a95a2869d97d5dd4c446fa08
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M resolve.c

  Log Message:
  -----------
  resolve: fix possible crash when proto is not specified

Fixes Coverity CID 40642

  Commit: c901d82241f5582299fbcd985c84be902a7f5f04
      https://github.com/OpenSIPS/opensips/commit/c901d82241f5582299fbcd985c84be902a7f5f04
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M parser/parse_methods.c

  Log Message:
  -----------
  fix impossible_and condition for method parsing

Fixes Coverity CID 40556

  Commit: 89fa77c4201c06c6a958dba1aff24e07acb350ec
      https://github.com/OpenSIPS/opensips/commit/89fa77c4201c06c6a958dba1aff24e07acb350ec
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M modules/acc/acc_vars.c
    M modules/compression/compression.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_replication.c
    M modules/dispatcher/dispatch.c
    M modules/dispatcher/dispatch.h
    M modules/dispatcher/dispatcher.c
    M modules/dns_cache/dns_cache.c
    M modules/drouting/routing.c
    M modules/emergency/sip_emergency.c
    M modules/fraud_detection/fraud_detection.c
    M modules/nathelper/nathelper.c
    M modules/proto_hep/proto_hep.c
    M modules/rtpengine/rtpengine.c
    M modules/rtpengine/rtpengine_funcs.c
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/rtpproxy_admin.xml
    M modules/rtpproxy/rtpproxy.c
    M modules/sipmsgops/README
    M modules/sipmsgops/doc/sipmsgops_admin.xml
    M modules/sipmsgops/sipmsgops.c
    M msg_translator.c
    M msg_translator.h
    M net/proto_udp/proto_udp.c
    M net/trans.c
    M parser/parse_body.c
    M parser/parse_body.h
    M parser/parse_methods.c
    M parser/sdp/sdp.c
    M resolve.c

  Log Message:
  -----------
  Merge branch 'master' into coverity_scan

Compare: https://github.com/OpenSIPS/opensips/compare/0a0e67476379...89fa77c4201c