[OpenSIPS-Devel] [OpenSIPS/opensips] 278730: Improve robustness of core URI copying functions

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2787308f68e6ee878dcf710cd7b36992af62aab9
      https://github.com/OpenSIPS/opensips/commit/2787308f68e6ee878dcf710cd7b36992af62aab9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2016-03-24 (Thu, 24 Mar 2016)

  Changed paths:
    M parser/msg_parser.c
    M serialize.c

  Log Message:
  -----------
  Improve robustness of core URI copying functions

Namely set_ruri(), set_dst_uri(), set_path_vector().

This patch corrects the behaviour of the above functions when they are
fed strange/corrupt strings, such as {NULL, 5} or {0x7fb..., 0}.

There are still plenty of pieces of OpenSIPS code which assume such
strings should be correctly processed, e.g. next_branches(), which may
lead to a whole world of problems ranging from segfaults, double free
operations and dangling pointers all the way up to intermixed shm/pkg
memory pointers.

The best way of addressing this issue is to simply accept such input and
zeroize (and free) the concerned sip_msg attributes.

Many thanks to Ovidiu Sas <osas at voipembedded.com> for in-depth error
reporting and assistance in fixing this issue