[OpenSIPS-Devel] [OpenSIPS/opensips] a8bcee: Fix crash when using $si in non SIP routes.

Bogdan-Andrei Iancu bogdan at opensips.org
Thu Mar 17 21:36:26 CET 2016


  Branch: refs/heads/1.11
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a8bcee45f63fcd3e5618857cb9c70a461cbcf799
      https://github.com/OpenSIPS/opensips/commit/a8bcee45f63fcd3e5618857cb9c70a461cbcf799
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M evi/event_interface.c
    M pvar.c
    M route.c
    M timer.c

  Log Message:
  -----------
  Fix crash when using $si in non SIP routes.

If using $si in event, timer or startup routes, return a NULL value.
Use a dummy AF_INET from src and dst IPs.
Prevent crashing while evaluating $si by checking return code of ip_addr2a()
Closes #817
Outdates #828

(cherry picked from commit 2d0cebc0be2491984ce357afd89d41212866bc06)

Conflicts:
	modules/dialog/dlg_req_within.h
	modules/event_route/route_send.c


  Commit: d5c3bd1eed5f40f7425562f8bb65fe2f5c9fc678
      https://github.com/OpenSIPS/opensips/commit/d5c3bd1eed5f40f7425562f8bb65fe2f5c9fc678
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2016-03-17 (Thu, 17 Mar 2016)

  Changed paths:
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  Reset to 0 the whole branch if failed.

If we do not reset, on trying to add the next branch (on the same position), we will end up with dangling pointers.


Compare: https://github.com/OpenSIPS/opensips/compare/f13253a65b8c...d5c3bd1eed5f


More information about the Devel mailing list