[OpenSIPS-Devel] [opensips] Avoid segfault and return NULL value for $si if empty (#828)

rrb3942 notifications at github.com
Tue Mar 15 18:33:06 CET 2016


After upgrading some systems from 1.10 to 1.11 I started receiving segfaults that I traced back to accessing $si when it was not populated in the msg and a failure to correctly check the return value of ip_addr2a(). I believe it only happened on internally generated requests.

Not sure what changed between 1.10 and 1.11 to trigger this, but this patch fixes the crash and seems to match 1.10 behavior.
You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSIPS/opensips/pull/828

-- Commit Summary --

  * Avoid segfault and return NULL value for $si if empty

-- File Changes --

    M pvar.c (10)

-- Patch Links --

https://github.com/OpenSIPS/opensips/pull/828.patch
https://github.com/OpenSIPS/opensips/pull/828.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/828
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20160315/abd26762/attachment.htm>


More information about the Devel mailing list