[OpenSIPS-Devel] [opensips] Fixed contact not preserved in resume route (#807)

[Bogdan Andrei IANCU]

@ionutrazvanionita, as per our discussion, the fix makes no sense at this point. The nathelper module uses some dirty tricks to remember the changed contact, and these tricks get into conflict with how lumps are managed during transaction creation (and sip request cloning in shm mem). Fixing it will be to add yet another even uglier hack and as time as there is a workaround at script level, let's avoid the hacks.
@ionutrazvanionita , please add a comment in documentation, for fix_nated_contact() function - you should not do an async call between fix_nated_contact() and save(location). Do the fix_nated_contact() after the last async call.
The idea is to have this properly fixed when reworking the lumps system in 3.x version.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/807#issuecomment-193768248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20160308/c61b0033/attachment.htm>