[OpenSIPS-Devel] [OpenSIPS/opensips] c23428: Completely remove script flags

Liviu Chircu liviu at opensips.org
Mon Mar 7 17:52:54 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c234282fc0cdc6cb7b418086c3ab1bad4ea4e1c4
      https://github.com/OpenSIPS/opensips/commit/c234282fc0cdc6cb7b418086c3ab1bad4ea4e1c4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M action.c
    M cfg.lex
    M cfg.y
    M flags.c
    M flags.h
    M modules/tm/uac.c
    M pvar.c
    M route.c
    M route_struct.c
    M route_struct.h

  Log Message:
  -----------
  Completely remove script flags

Namely, setsflag(), resetsflag(), issflagset()

With the advent of async operations, the delimitation between current
SIP message context and script context is even more blurry.

Fixing the script flags to work with async would involve storing them
into message context. But that would also make them persistent through
failure route. In turn, this breaks the concept of scripts flags, since
they should only live through a single script execution (entry->exit).

To sum up, we dropped script flags because async silently broke them,
and fixing them would actually break them even more!




More information about the Devel mailing list