[OpenSIPS-Devel] [OpenSIPS/opensips] 4c54bc: Fix evaluating the SIP port from a SIP URI.

[Bogdan-Andrei Iancu]

Hi Olle,

Yes, indeed, after an SRV lookup, the port may change, but what this 
commit fixes is the SIP URI matching (URI as it is, without considering 
how this URI may resolve based on DNS). The URI changes based on DNS is 
another level, which is out of the scope of this fix.
The fix is mainly about proper evaluation of the port in a SIP URI 
(without resolving the URI).

Regards,

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com

On 09.06.2016 15:06, Olle E. Johansson wrote:
>> On 08 Jun 2016, at 11:56, Bogdan-Andrei Iancu <bogdan at opensips.org> wrote:
>>
>> NOTE: it is completly bogus (and dangerous) to assue 5061 if SIPS schema is used as:
>> 1) SIPS can use used with WSS, which actually has 443 port
>> 2) TLS can pe required via transport param in a SIP schema URI too
>>
> 3) SIPS can get different port in SRV.
>
> Good observation! Assuming a port is quite often dangerous.
>
> /O