[OpenSIPS-Devel] [opensips] Proposed fix for erratic nat_traversal keepalives (#751)

[Saúl Ibarra Corretgé]

Hey @bogdan-iancu, thanks for chiming in :-)

> that may simplify your patch a lot - the nat_helper timer routing is registered with "TIMER_FLAG_DELAY_ON_DELAY" - this guarantees that (even executed in various processes) the handler will not be run in parallel (all its executions will be serial). So you do not need locking at all. Also, the counter itself can shm allocated and its pointer can be passed to the timer handler (more elegant versus a global var).

This sounds like a better approach to me, can you adjust to it @aerringer? Thanks a lot!

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/751#issuecomment-171261698
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20160113/08729c53/attachment.htm>