[OpenSIPS-Devel] [OpenSIPS/opensips] bce530: Fix the sizing of the Async Reactors.

[Bogdan-Andrei Iancu]

Hi Maxim,

Thanks for reporting and checking. The actual fix is in this commit:

https://github.com/OpenSIPS/opensips/commit/12d27ab2c0c081ecd3f89a77b9f49d8a41240999

Best regards.

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com

On 04.02.2016 07:23, Maxim Sobolev wrote:
> Hi Bogdan, it looks like that issue is fixed in one of the later 
> commits. Today's build is fine, no issues. I've added some new test 
> cases to check basic re-INVITE handling and more will be coming soon. 
> Thanks!
>
> https://travis-ci.org/sippy/voiptests/builds/106897389
>
> On Mon, Feb 1, 2016 at 7:28 AM, Bogdan-Andrei Iancu 
> <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>
>     Maxim,
>
>     one more thing: the fd array size = sizeof(struct pollfd) *
>     reactor_size . On 64bit arch, sizeof(struct pollfd) is 8 bytes. As
>     you error reports a request of 1536000 bytes, that means 192000
>     file descriptors (based on ulimit -n). That is a bit high imho,
>     for any system....
>
>     Could you try to start in debug mode (debug=4) and see the logs
>     from set_open_fds_limit function please ?
>
>     I'm trying to rule out any programming bug (versus a design bug).
>
>     Thanks and Regards,
>
>     Bogdan-Andrei Iancu
>     OpenSIPS Founder and Developer
>     http://www.opensips-solutions.com
>
>     On 29.01.2016 22:08, Maxim Sobolev wrote:
>>     This is just the default Travis linux instance. I don't set any
>>     flags to bump that limit specifically. I think the default there
>>     is 4k or something along those lines.
>>
>>     On Thu, Jan 28, 2016 at 11:35 PM, Bogdan-Andrei Iancu
>>     <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>>
>>         Woow....what is the value of open_files_limit you use ? or if
>>         you do not explicitly set, what is the soft limit for open
>>         files for the user you are using to run opensips ?
>>
>>         Regards,
>>
>>         Bogdan-Andrei Iancu
>>         OpenSIPS Founder and Developer
>>         http://www.opensips-solutions.com
>>
>>         On 29.01.2016 04:13, Maxim Sobolev wrote:
>>>         I think this broke 2.1:
>>>
>>>         Jan 29 00:43:48 [12422] WARNING:core:main: no fork mode
>>>         Jan 29 00:43:48 [12422] NOTICE:core:main: version: opensips
>>>         2.1.2 (x86_64/linux)
>>>         Jan 29 00:43:48 [12422] WARNING:core:fm_malloc: Not enough
>>>         free memory, will attempt defragmentation
>>>         Jan 29 00:43:48 [12422] CRITICAL:core:init_io_wait: could
>>>         not alloc fd array (1536000 bytes)
>>>         Jan 29 00:43:48 [12422] ERROR:core:udp_rcv_loop: failed to
>>>         init reactor
>>>
>>>         Full log is here:
>>>
>>>         https://travis-ci.org/sippy/voiptests/jobs/105566025
>>>
>>>         On Thu, Jan 28, 2016 at 3:55 AM, Bogdan-Andrei Iancu
>>>         <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>>>
>>>             Branch: refs/heads/2.1
>>>               Home: https://github.com/OpenSIPS/opensips
>>>               Commit: bce5306bb28c3b80e85c610e6ee4eb55603bdeb1
>>>             https://github.com/OpenSIPS/opensips/commit/bce5306bb28c3b80e85c610e6ee4eb55603bdeb1
>>>               Author: Bogdan-Andrei Iancu <bogdan at opensips.org
>>>             <mailto:bogdan at opensips.org>>
>>>               Date:   2016-01-28 (Thu, 28 Jan 2016)
>>>
>>>               Changed paths:
>>>                 M daemonize.c
>>>                 M daemonize.h
>>>                 M main.c
>>>                 M net/net_tcp.c
>>>                 M net/net_tcp_proc.c
>>>                 M net/net_tcp_proc.h
>>>                 M net/net_udp.c
>>>
>>>               Log Message:
>>>               -----------
>>>               Fix the sizing of the Async Reactors.
>>>
>>>             Adjust the size of the reactor accroding the limit of
>>>             opens files.
>>>             Closing #765.
>>>
>>>             (cherry picked from commit
>>>             2efdbf8c45a35c57754ac14e64a356b9bb74fd5f)
>>>
>>>
>>>
>>>             _______________________________________________
>>>             Devel mailing list
>>>             Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>>>             http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>>
>>>
>>>
>>>
>>>         -- 
>>>         Maksym Sobolyev
>>>         Sippy Software, Inc.
>>>         Internet Telephony (VoIP) Experts
>>>         Tel (Canada): +1-778-783-0474 <tel:%2B1-778-783-0474>
>>>         Tel (Toll-Free): +1-855-747-7779 <tel:%2B1-855-747-7779>
>>>         Fax: +1-866-857-6942 <tel:%2B1-866-857-6942>
>>>         Web: http://www.sippysoft.com
>>>         MSN: sales at sippysoft.com <mailto:sales at sippysoft.com>
>>>         Skype: SippySoft
>>
>>
>>
>>
>>     -- 
>>     Maksym Sobolyev
>>     Sippy Software, Inc.
>>     Internet Telephony (VoIP) Experts
>>     Tel (Canada): +1-778-783-0474 <tel:%2B1-778-783-0474>
>>     Tel (Toll-Free): +1-855-747-7779 <tel:%2B1-855-747-7779>
>>     Fax: +1-866-857-6942 <tel:%2B1-866-857-6942>
>>     Web: http://www.sippysoft.com
>>     MSN: sales at sippysoft.com <mailto:sales at sippysoft.com>
>>     Skype: SippySoft
>
>
>
>
> -- 
> Maksym Sobolyev
> Sippy Software, Inc.
> Internet Telephony (VoIP) Experts
> Tel (Canada): +1-778-783-0474
> Tel (Toll-Free): +1-855-747-7779
> Fax: +1-866-857-6942
> Web: http://www.sippysoft.com
> MSN: sales at sippysoft.com <mailto:sales at sippysoft.com>
> Skype: SippySoft

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20160204/f7ec2524/attachment-0001.htm>