[OpenSIPS-Devel] [opensips] added exec(cmd, output, input, avpenv) function for exec module (#360)

[Walter Doekes]

> @@ -243,6 +246,48 @@ exec_getenv("HOSTNAME");
>  exec_getenv("HOSTNAME", "$avp(localhost)");
>  ...
>  
> +1.4.5.  exec(command, [output], [input], [envavp])
> +
> +   Executes an external command. The input is passed to the
> +   standard input of the new process, if specified, and the output
> +   is saved in the output variable.
> +
> +   Meaning of the parameters is as follows:
> +     * command - command to be executed.It can include
> +       pseudovariables.
> +     * output - pseudovariable where to store the output from the
> +       standard output of the command. Keep in mind that if this
> +       parameter is set, the async paramater will not be taken in
> +       consideration.

I see that it's not supported in your code.

My point was that if you define the function like you do:

    exec(command, [output], [input], [envavp])

it would be quirky to add stderr later:

    exec(command, [output], [input], [envavp], [stderr])

You see how the argument order doesn't make sense.

So, it was less of a question of whether it exists, and more of a suggestion to add it now, while you're still free to define the function in the most logical manner.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/360/files#r19004237
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20141017/c8da94e4/attachment.htm>