[OpenSIPS-Devel] [opensips] load_balancer module enhancements (#345)
Bogdan Andrei IANCU
notifications at github.com
Thu Oct 16 12:46:07 CEST 2014
I start reviewing the patches and :
- the first patch - a7549e00bdd3fd13fc20777bccf935d41303980e - I do not agree with the approach - once you started a LB session, you should not change the set or resources. If you need to do that, first reset the existing LB session and then create a new one.
- patch 2 and 3 are ok as functionality - please make a separate PR with them, so I can accept them.
- patch 4 - I do not see any reason for defining the _NEG algs, as the only difference is about handling the negative values - we could simply do that all the time....
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Devel