[OpenSIPS-Devel] [OpenSIPS/opensips] 9271a4: Replace odd -j in module-submake with ability for ...

Razvan Crainea razvan at opensips.org
Wed Mar 19 18:07:55 CET 2014


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9271a45ec22a8d96a340870ed491f244f1ed982b
      https://github.com/OpenSIPS/opensips/commit/9271a45ec22a8d96a340870ed491f244f1ed982b
  Author: Walter Doekes <walter+github at wjd.nu>
  Date:   2014-03-19 (Wed, 19 Mar 2014)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Replace odd -j in module-submake with ability for proper parallelism.

Recently `-j` was added to the list of flags passed to the modules
$(MAKE) command. That's bad practise for two reasons: (1) the caller
should decide on how much -j is required, not the programmer, and (2)
just -j without any numeric argument is "use all resources you can
get", which can be too much.

We order the Makefile around so the supermake (the user invocation)
can dispatch individual submakes in a parallel fashion. This is done
by (a) making the module directories phony targets and (b) replacing
the sequential for-loop over the modules with a simple dependency.


  Commit: 67cfefee2e654f732201b671f3b1137b7c41467c
      https://github.com/OpenSIPS/opensips/commit/67cfefee2e654f732201b671f3b1137b7c41467c
  Author: Walter Doekes <walter+github at wjd.nu>
  Date:   2014-03-19 (Wed, 19 Mar 2014)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Address concerns: clearly note that there was an error.


  Commit: 176a41ff614a5dfc91b21398092904939fa27218
      https://github.com/OpenSIPS/opensips/commit/176a41ff614a5dfc91b21398092904939fa27218
  Author: Walter Doekes <walter+github at wjd.nu>
  Date:   2014-03-19 (Wed, 19 Mar 2014)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Address concern: readability of compiling modules without -j.


  Commit: beb383f260c17895eb6a0950a892f0b67cc2b711
      https://github.com/OpenSIPS/opensips/commit/beb383f260c17895eb6a0950a892f0b67cc2b711
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2014-03-19 (Wed, 19 Mar 2014)

  Changed paths:
    M Makefile
    M Makefile.rules

  Log Message:
  -----------
  makefile: add FASTER variable

Increase the compile time of opensips by compiling all modules in parallel.
Because the output of the command gets mixed and it is hard to parse, we
simply suppress it.
Usage example: FASTER=1 make -j all


Compare: https://github.com/OpenSIPS/opensips/compare/0260de0c1bdc...beb383f260c1


More information about the Devel mailing list