[OpenSIPS-Devel] [opensips] [drouting] Testing roules through MI now posssible (#293)

[Răzvan Crainea]

> +
> +static struct mi_root* mi_dr_test_number(struct mi_root *cmd_tree, void *param)
> +{
> +    struct mi_node *node = cmd_tree->node.kids;
> +    struct head_db *partition;
> +    str s;
> +    int grp_id;
> +    rt_info_t *route;
> +
> +    if (node == NULL)
> +        return init_mi_tree(400, MI_MISSING_PARM_S, MI_MISSING_PARM_LEN);
> +
> +    if (use_db_config) {
> +        s = node->value;
> +        if((partition = get_partition(&s)) == NULL) {
> +            LM_CRIT("Partition <%.*s> was not found.\n", s.len, s.s);

I don't think we should have a CRIT message here. Nothing critical happens if the partition is not found. Probably a WARNING would be more suitable.

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/293/files#r16039847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20140811/eada9c62/attachment.htm>