[OpenSIPS-Devel] [opensips] Core dump of 1.10 when logging cdr (#283)

[MayamaTakeshi]

I am testing with this recent commit:

opensips-1.10# git log |head
commit 3ba12dde91011a235d26186afdf24cb9561c416e
Author: Vlad Paiu <vladpaiu at opensips.org>
Date:   Tue Jul 22 12:30:04 2014 +0300

    Check for all negative values when fetching cachedb counter
    (cherry picked from commit 17bc5d970d18a01c4e08a512691264ce3a8c4a80)

Here is the backtrace:

http://pastebin.com/Kvmr5YDH

There is only one commit above this one, but it doesn't look an upgrade would solve this:

opensips-1.10# git diff HEAD 3ba12dde91011a235d26186afdf24cb9561c416e
diff --git a/modules/cfgutils/script_locks.c b/modules/cfgutils/script_locks.c
index 05fcc60..91d4e12 100644
--- a/modules/cfgutils/script_locks.c
+++ b/modules/cfgutils/script_locks.c
@@ -179,13 +179,11 @@ void destroy_script_locks(void)
                lock_entry = static_locks;
                static_locks = static_locks->next;
 
-               if (lock_entry->lock)
-                       lock_dealloc(lock_entry->lock);
+               lock_dealloc(lock_entry->lock);
                shm_free(lock_entry);
        }
 
        /* Free all dynamic locks  */
-       if (dynamic_locks)
-               lock_set_dealloc(dynamic_locks);
+       lock_set_dealloc(dynamic_locks);
 }
 


---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/283
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20140731/763d0810/attachment.htm>