[OpenSIPS-Devel] [OpenSIPS/opensips] e34424: Fixed RFC 4235 notifications compliance.

Bogdan Andrei IANCU bogdan at opensips.org
Tue Sep 3 18:16:43 CEST 2013


  Branch: refs/heads/1.8
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e344240b1dd2f1f2e9b71cdcd991718e4461d28c
      https://github.com/OpenSIPS/opensips/commit/e344240b1dd2f1f2e9b71cdcd991718e4461d28c
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M modules/presence/notify.c
    M modules/presence/notify.h
    M modules/presence/presence.c
    M modules/presence/presentity.c
    M modules/presence/publish.c
    M modules/presence/subscribe.c
    M modules/presence_dialoginfo/notify_body.c

  Log Message:
  -----------
  Fixed RFC 4235 notifications compliance.

The RFC states that a NOTIFY sent after a SUBSCRIBE (initial
or refreshed) must contain a full state notification.
However, a NOTIFY sent after a PUBLISH must contain a partial state
indicating the specific state change.

Without this patch, OpenSIPS actually publishes a full state
notification in all cases (despite announcing a partial notification),
making the publish ordering fix patch useless.


  Commit: ec336a3b4fea02b4e7d221e5b5b9668073b03186
      https://github.com/OpenSIPS/opensips/commit/ec336a3b4fea02b4e7d221e5b5b9668073b03186
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M modules/presence/notify.c
    M modules/presence_dialoginfo/notify_body.c

  Log Message:
  -----------
  Code beautification.

Use a 4-chars wide tab for indentation instead of spaces.


  Commit: 09a291eb0bd250f715bc89894c22688f713e4dce
      https://github.com/OpenSIPS/opensips/commit/09a291eb0bd250f715bc89894c22688f713e4dce
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M modules/presence/notify.c
    M modules/presence/notify.h
    M modules/presence/presence.c
    M modules/presence/presentity.c
    M modules/presence/publish.c
    M modules/presence/subscribe.c
    M modules/presence_dialoginfo/notify_body.c

  Log Message:
  -----------
  Merge pull request #62 from dsandras/ds-dialoginfo-notifications-fixes

Fixed RFC 4235 notifications compliance.


Compare: https://github.com/OpenSIPS/opensips/compare/4c0b862b0fe7...09a291eb0bd2


More information about the Devel mailing list