[OpenSIPS-Devel] [ opensips-Bugs-3607114 ] Media-Proxy may wrongly close relay ports

[SourceForge.net]

Bugs item #3607114, was opened at 2013-03-06 19:55
Message generated for change (Comment added) made by yeyingxian
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3607114&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: yeyingxian (yeyingxian)
Assigned to: Nobody/Anonymous (nobody)
Summary: Media-Proxy may wrongly close relay ports

Initial Comment:
The current implementation of mediaproxy.c has a flag called skip_next_reply in structure ice_candidate_data. 

//   - skip_next_reply: flag for knowing the fact that the next reply with SDP must be skipped 
//     because it is a reply to a re-INVITE or UPDATE *after* the ICE negotiation 

But this flag only ignores the first reply to re-INVITE, and resets to false after the first reply comes. 


    } else if (msg->first_line.type == SIP_REPLY) { 
        if (ice_data != NULL && ice_data->skip_next_reply) { 
            // we don't process replies to ICE negotiation end requests 
            // (those containing a=remote-candidates) 
            ice_data->skip_next_reply = False;
            return -1; 
        } 

In 2G or other low speed network, UAS may retransmit SIP reply more than once. Thus media-proxy may still process these replies and wrongly open new ports for relay or even close the ports that are being used. Here is my log for media-proxy in such situation. Is there any idea to fix this bug? 

----------------------------------------------------------------------

Comment By: yeyingxian (yeyingxian)
Date: 2013-03-07 04:59

Message:
Hi saghul,

I uploaded the captured sip messages. The dialog whose call-id is OUxwFrwW
causes this problem. And log.txt is the log of media-proxy and media-relay.
My IP of my Sip Server is 211.154.154.77. Is it enough?

----------------------------------------------------------------------

Comment By: saghul (saghul)
Date: 2013-03-07 00:04

Message:
Can you please attach a SIP trace of such a call?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3607114&group_id=232389