[OpenSIPS-Devel] [ opensips-Patches-3580526 ] NATHELPER and OPTIONS ping for tcp proto

SourceForge.net noreply at sourceforge.net
Wed Jan 23 10:29:57 CET 2013


Patches item #3580526, was opened at 2012-10-26 05:52
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3580526&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Liviu Chircu (liviuchircu)
Summary: NATHELPER and OPTIONS ping for tcp proto

Initial Comment:
nathelper don't want to ping abonents with TCP transport.

Here is a small patch:


Index: modules/nathelper/nathelper.c
===================================================================
--- modules/nathelper/nathelper.c       (revision 9391)
+++ modules/nathelper/nathelper.c       (working copy)
@@ -1228,8 +1228,6 @@
                                continue;
                        }
                }
-               if (curi.proto != PROTO_UDP && curi.proto != PROTO_NONE)
-                       continue;
                if (curi.port_no == 0)
                        curi.port_no = SIP_PORT;
                proto = curi.proto;


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2013-01-23 01:29

Message:
Your patch was not correct as even if you were allowing pinging for TCP
contacts too, the pinging was still done via UDP.

Liviu added a new parameter to control when to do TCP pinging:
, see http://www.opensips.org/Main/Ver190#toc13 .

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-11-01 05:34

Message:
Hello,

Seems a little dangerous to start ping-ing TCP clients with Options. First
thing that would need to be added is the tcp_no_new_conn_bflag , in order
not to open a new connection if the old one is down.

But still, couldn't we just use the tcp_keepalive param ( see [1] ) ?

Can you give some examples of cases where you need explicit SIP Option
pings over TCP ?

[1] http://www.opensips.org/Resources/DocsCoreFcn18#toc84

Regards,
Vlad

----------------------------------------------------------------------

Comment By: Nick Altmann (nikbyte)
Date: 2012-10-29 23:29

Message:
Uploaded patch to add sipping_tcp option.

----------------------------------------------------------------------

Comment By: Nick Altmann (nikbyte)
Date: 2012-10-29 01:00

Message:
I think you disable OPTIONS because we can use tcp keepalives. But
sometimes we need exactly OPTIONS pings via tcp protocol. I suggest to add
a module option to enable/disable OPTIONS pings via tcp.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3580526&group_id=232389



More information about the Devel mailing list