[OpenSIPS-Devel] [opensips] route.c: 4 * bad if test ? (#146)

[dcb314]

I just ran the source code of opensips-1.10.0 through
the static analyser cppcheck. It said many things,
including

[route.c:1151] -> [route.c:1151]: (style) Same expression on both sides of '>'.
[route.c:1161] -> [route.c:1161]: (style) Same expression on both sides of '>='.
[route.c:1171] -> [route.c:1171]: (style) Same expression on both sides of '<'. [route.c:1181] -> [route.c:1181]: (style) Same expression on both sides of '<='.

Source code for the first one is

            else if(rt==0 && s1->len>s1->len)

Suggest code rework.


---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20131206/a344c6d8/attachment.htm>