[OpenSIPS-Devel] [OpenSIPS/opensips] f7dae1: Improved PUA DialogInfo.

Bogdan Andrei IANCU bogdan at opensips.org
Fri Aug 2 16:58:05 CEST 2013


  Branch: refs/heads/1.8
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f7dae1d43420149f715d761f97f36e1143be54ff
      https://github.com/OpenSIPS/opensips/commit/f7dae1d43420149f715d761f97f36e1143be54ff
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  Improved PUA DialogInfo.

Several fixes here:
  - Dialog callbacks are now correctly setup after a restart of
    OpenSIPS. In other words, restarting OpenSIPS will not lead to ghost BLFs
    anymore.
  - Added an option allowing not to publish state change in case of reINVITE.
  - Added an option allowing not to publish state change in trying state.
    In other words, a PUBLISH will be sent only when OpenSIPS has received a
    18x response type and not before.


  Commit: 1e652a185c0ab3634fbdf11981bddca34d5fb832
      https://github.com/OpenSIPS/opensips/commit/1e652a185c0ab3634fbdf11981bddca34d5fb832
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M modules/presence_dialoginfo/notify_body.c

  Log Message:
  -----------
  Fixed dialog-info problems in case there is no dialog.

Without that patch, when OpenSIPS does not find any active dialog
and needs to NOTIFY that state, it correctly sends a full state dialog
information, but the XML document is wrong.

This is the wrong format, the one that was used:
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info"
version="0" state="partial" entity="sip:752 at ds.local.beip.be"><dialog
id="752"><state>terminated</state></dialog></dialog-info>
(info is not partiali but full, dialog id is wrong).

This is the correct format:
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info"
version="6" state="full" entity="sip:753 at ds.local.beip.be"/>


  Commit: caf72d682f58feea8530b1da6462efa255514732
      https://github.com/OpenSIPS/opensips/commit/caf72d682f58feea8530b1da6462efa255514732
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-07-26 (Fri, 26 Jul 2013)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  Removed publish_on_reinvite option.

Disabling PUBLISH on reINVITEs has some side effects when being used
with session timers. More specifically, the session timer could be
refresh, but the PUA PUBLISH could expire because it is not refreshed
at the same time of the dialog when being setup with the initial dialog
lifetime.


  Commit: 7ceae5bff5e12dd2b297ac04183e991a7ee5c532
      https://github.com/OpenSIPS/opensips/commit/7ceae5bff5e12dd2b297ac04183e991a7ee5c532
  Author: Damien Sandras <dsandras at beip.be>
  Date:   2013-07-29 (Mon, 29 Jul 2013)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  Several in-DIALOG PUBLISH fixes.

The number of generated PUBLISH requests is no optimal.

Disabled PUBLISHing for in-dialog REQUESTS. PUBLISHing (again) the
"confirmed" state when handling OPTIONS, ACK, BYE, and other dialog related
requests triggers a mess of useless NOTIFY requests. We only keep PUBLISHing
on reINVITE/UPDATEs as that might be required to be compatible with session
timers (they refresh the PUBLISH lifetime).

Also added a flag to allow inhibiting PUBLISHing for INVITE/UPDATE in-dialog
requests. That might be required for "things" like Asterisk reINVITEs for which
we do not want rePUBLISHing again our "confirmed" state. Especially useful when
you know that Asterisk reINVITEs for INFO, BYE, and so on.


  Commit: a524780406b6e6a50e92cc348684b4680fe83bc7
      https://github.com/OpenSIPS/opensips/commit/a524780406b6e6a50e92cc348684b4680fe83bc7
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2013-08-02 (Fri, 02 Aug 2013)

  Changed paths:
    M modules/presence_dialoginfo/notify_body.c
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  Merge pull request #15 from dsandras/ds-better-pua-dialoginfo

Ds better pua dialoginfo

Thank you for the fixes! Please provide the update on the docs too !

Credits go to Damien Sandras from Be IP s.a. @ http://www.beip.be


Compare: https://github.com/OpenSIPS/opensips/compare/ab8b4fe1664a...a524780406b6


More information about the Devel mailing list