[OpenSIPS-Devel] [ opensips-Bugs-3576351 ] sip_trace module bug

[SourceForge.net]

Bugs item #3576351, was opened at 2012-10-11 07:53
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3576351&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dragos Oancea (dragosoancea)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: sip_trace module bug

Initial Comment:
Hi

The siptrace module reports a wrong value in the `fromip` field of the sip_trace table. 

For example , for this INVITE, coming from tls:80.187.x.x:62510 , I would expect the value "tls:80.187.x.x:62510" to be added in the `fromip` field,
but it's adding "tls:80.187.x.x:625" instead . It's missing two digits from the port value.
Also , sometimes it would put its local port (in my case 5061) instead of the remote port in the `fromip` or `toip` fields.


INVITE sips:+49170738xxxx at sip.domain.com SIP/2.0
Call-Id: c64e6615c79ab23501ad13f2e1a58918 at 10.77.26.75
CSeq: 1 INVITE
Via: SIP/2.0/TLS 10.77.26.75:59076;branch=z9hG4bK127109c14cd3b59c9ef9909b737982ab
Max-Forwards: 70
From: "+491713xxxxx" <sips:username at sip.domain.com>;tag=yRkyOWfbq
To: <sips:+4917073xxxxx at sip.domain.com>
Contact: <sips:00xxxx at 80.187.x.x:62510;transport=tls>
Allow: ACK,BYE
User-Agent: SomeUserAgent
Content-Type: application/sdp
Content-Length: 138

v=0
o=- 1349965870484 1349965870484 IN IP4 10.77.26.75
s=-
c=IN IP4 10.77.26.75
t=0 0
m=audio 37566 RTP/AVP 0
a=rtpmap:0 PCMU/8000



The problem was observed with opensips 1.8.1-tls and opensips-1.7.2-tls . 

Cheers,
Dragos



----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-10-12 06:30

Message:
Dragos, apply this patch -> it will print to logs (on critical level) the
calculated FROMIP and TOIP values. When you find bogus entries in siptrace,
you can try to correlate with the log to see if the values from logs are
also truncated.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Dragos Oancea (dragosoancea)
Date: 2012-10-12 04:51

Message:
Hi

Yes, it happens very often,I don't know why . Sometime it puts the correct
values into the fields (for messages within the same dialog I could see
some entries  -requests or replies - added with the correct port , but 
some are missing one or two digits ),

If you provide the patch I'll apply it.

Cheers,
Dragos

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-10-12 04:22

Message:
Can you reproduce that? if so, I will provide a small patch to print some
extra logs - the idea is to see if the truncation comes from the siptrace
or the mysql module 

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3576351&group_id=232389