[OpenSIPS-Devel] [ opensips-Bugs-3587163 ] Commit #9295 breaks dispatcher

[SourceForge.net]

Bugs item #3587163, was opened at 2012-11-14 08:43
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3587163&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.8.x
Status: Open
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Dynamic Packet (dpacket)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Commit #9295 breaks dispatcher

Initial Comment:
It seems commit #9295 on 1.8 branch breaks AVP in certain cases. Opensips starts fine and some avp related stuff works, but certain scenarios cause this: 

Nov 14 11:13:40 ip-10-173-81-249 /usr/sbin/opensips[1042]: ERROR:core:new_avp: invalid AVP name!
Nov 14 11:13:40 ip-10-173-81-249 /usr/sbin/opensips[1042]: ERROR:core:add_avp: Failed to create new avp structure

Script now does not execute as it should and in the end cause failures in call processing.  Its possible this also effects trunk (commit #9294) . I have tested by reverting this single commit (#9295) in most resent stable 1.8 and issue is resolved.

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-11-22 06:04

Message:
I checked the code (trunk + 1,8) and I see the fix there. Are you sure you
are using the latest 1.8 version ? maybe you do not have the fix in your
checkout.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-11-21 08:39

Message:
I remember fixing this - I will check the backports

----------------------------------------------------------------------

Comment By: Dynamic Packet (dpacket)
Date: 2012-11-14 10:29

Message:
This is a bug in dispatcher module. If you fail to set attrs_avp in script,
you get errors on ds_select_dst().  Default, per docs, should be null. But
ds_select_dst fails in this case after commit #9295. Setting attrs_avp in
config, seemingly fixes the issue.

----------------------------------------------------------------------

Comment By: Dynamic Packet (dpacket)
Date: 2012-11-14 09:01

Message:
Hi Razvan,

I'm not 100% sure what function and I am unable to test at the moment. But
looking at the area of the script it occurs in, it could be ds_select_ds,
append_hf, xlog or least likely script comparisons/assignments.

----------------------------------------------------------------------

Comment By: Razvan Crainea (razvancrainea)
Date: 2012-11-14 08:55

Message:
Hi!

Can you tell us when do you receive those errors? Is it a certain function
that uses AVPs and cannot find them?

Regards,
Răzvan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3587163&group_id=232389