[OpenSIPS-Devel] [ opensips-Patches-3580526 ] NATHELPER and OPTIONS ping for tcp proto
SourceForge.net
noreply at sourceforge.net
Thu Nov 1 12:55:37 CET 2012
Patches item #3580526, was opened at 2012-10-26 05:52
Message generated for change (Settings changed) made by vladut-paiu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3580526&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: modules
>Group: 1.8.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Nobody/Anonymous (nobody)
Summary: NATHELPER and OPTIONS ping for tcp proto
Initial Comment:
nathelper don't want to ping abonents with TCP transport.
Here is a small patch:
Index: modules/nathelper/nathelper.c
===================================================================
--- modules/nathelper/nathelper.c (revision 9391)
+++ modules/nathelper/nathelper.c (working copy)
@@ -1228,8 +1228,6 @@
continue;
}
}
- if (curi.proto != PROTO_UDP && curi.proto != PROTO_NONE)
- continue;
if (curi.port_no == 0)
curi.port_no = SIP_PORT;
proto = curi.proto;
----------------------------------------------------------------------
Comment By: Nick Altmann (nikbyte)
Date: 2012-10-29 23:29
Message:
Uploaded patch to add sipping_tcp option.
----------------------------------------------------------------------
Comment By: Nick Altmann (nikbyte)
Date: 2012-10-29 01:00
Message:
I think you disable OPTIONS because we can use tcp keepalives. But
sometimes we need exactly OPTIONS pings via tcp protocol. I suggest to add
a module option to enable/disable OPTIONS pings via tcp.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3580526&group_id=232389
More information about the Devel
mailing list