[OpenSIPS-Devel] [ opensips-Bugs-3521295 ] Fix PIDF aggregation

SourceForge.net noreply at sourceforge.net
Wed May 16 18:40:03 CEST 2012


Bugs item #3521295, was opened at 2012-04-25 02:00
Message generated for change (Comment added) made by saghul
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3521295&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: saghul (saghul)
Assigned to: saghul (saghul)
Summary: Fix PIDF aggregation

Initial Comment:
Hi,

The current code for PIDF aggregation produces invalid documents (ie they don't validate) mainly due to the ordering of XML elements in the resulting document. There is also no way to prevent OpenSIPS from automatically generating a PIDF when a PUBLISH with Expires: 0 is received.

The attached patch adds a new modparam to presence_xml 'generate_offline_body' (enabled by default) to control if offline PIDFs should be generated automatically. It also refactors the way PIDFs are aggregated to ensure the order is correct and duplicates are pruned.

Since the patch is quite big, I'll send an email to the -dev mailing list with a detailed explanation of the issues I discovered and how the patch addresses them.


Regards,

--
Saúl Ibarra Corretgé
AG Projects

----------------------------------------------------------------------

>Comment By: saghul (saghul)
Date: 2012-05-16 09:40

Message:
Hi Bogdan,

I'll commit the changes to branches 1.8 and trunk tonight then.


Regards,

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-05-16 09:18

Message:
Hi Saúl,

OK, perfect - please apply the patch on the relevant versions and close
this ticket when done.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: saghul (saghul)
Date: 2012-05-16 08:57

Message:
Hi Bogdan,

Thanks for looking into this. I did test the patch and it works well with
all aggregation tests I did, so I consider it stable. Even if code is
complicated, IMHO it's easier to follow now, so if issues arise they should
be easy to fix.

If any issue related to this is reported, feel free to assign it to me,
I'll take care of it.


Kind regards,
Saúl


----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-05-16 08:51

Message:
Hi Saúl,

Thank you for your patch - it looks really complicated (especially the
logic behind the changes), so I will ask you straight : have you tested
properly the patch ?  is it stable ?

If so, I will go on your hand (as having more experience on the
presence_xml stuff than me) and commit the patch.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: saghul (saghul)
Date: 2012-04-25 02:32

Message:
Miling list thread:
http://lists.opensips.org/pipermail/devel/2012-April/010345.html

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3521295&group_id=232389



More information about the Devel mailing list