[OpenSIPS-Devel] [ opensips-Bugs-3489766 ] 1.7.1 - dispatcher - options_reply_codes ignored

[SourceForge.net]

Bugs item #3489766, was opened at 2012-02-20 13:56
Message generated for change (Comment added) made by vladut-paiu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3489766&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Vladut-Stefan Paiu (vladut-paiu)
Summary: 1.7.1 - dispatcher - options_reply_codes ignored

Initial Comment:
If i set for example:
modparam("dispatcher", "options_reply_codes", "501, 403")
and a gateway responds "488 Not Acceptable Here" then the gateway remains active.

So it looks to me like the "options_reply_codes" is ignored.

----------------------------------------------------------------------

>Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-03-16 09:32

Message:
Hello,

I have just committed a fix for this in trunk.

Regards,
Vlad

----------------------------------------------------------------------

Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-02-21 05:36

Message:
Hello,

The current behavior is :
- in probing mode 0, GWs are probed with Options messages only when they
are in the Probing state. A received 200 OK reply or one of the codes in
the options_reply_codes parameter, makes the GW go back to the active
state
- in probing mode 1, all GWs are probed. Only a 408 timeout will make the
GWs to be marked as disabled

Indeed, this is a bug, as in probing mode 1, 408 and all codes other than
options_reply_codes should lead to marking the GW as disabled. 
But as this implies changing the OpenSIPS behavior, I have marked this bug
as belonging to the 'trunk' group and it will be fixed in the next OpenSIPS
1.8 release.

Regards,
Vlad


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2012-02-21 05:22

Message:
Yes, i have ds_probing_mode set to 1.
When i restart OpenSIPS this gateway is marked as active immediately but
the gateway always responds a 488.
Does this mean;
   - all gateways are marked active on startup and
   - a gateway that responds remains active whatever the reply code is?
Thank in advance!

----------------------------------------------------------------------

Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-02-21 03:21

Message:
Hello,

The options_reply_codes represent the codes that will be accepted when a
gateway is in probing and it being pinged in order to get it back to the
active state. So, for your example, when a GW is in probing and it replies
to an Options with 200, 501 or 403, it will be marked again as active.

In your case, do you have ds_probing_mode set to 1, so you ping all
gateways ?

Regards,
Vlad

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3489766&group_id=232389