[OpenSIPS-Devel] [ opensips-Bugs-3535432 ] avp parsing failure in h350

[SourceForge.net]

Bugs item #3535432, was opened at 2012-06-15 04:30
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3535432&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Yaroslav M Strilchuk (ditegen)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: avp parsing failure in h350

Initial Comment:
The server exits on h350 init with a brief complaint in log:

ERROR:h350:h350_auth_lookup_fixup: pv_parse_format failed
ERROR:core:fix_actions: fixing failed (code=-2) at cfg line 524
CRITICAL:core:fix_expr: fix_actions error
ERROR:core:main: failed to fix configuration with err code -2

In this particular case the failure happens only with debug=2 being set for non-debug build of the server and modules.
I didn't dig too hard but noticed that in h350_auth_lookup_fixup the first argument in the call pv_parse_format(&s,&model) is not properly initialized.
The patch in the attachment fixes the issue.


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-06-28 03:55

Message:
ping......

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-06-19 07:59

Message:
Hi Yaroslav,

I understand the part with nu-initialized  (s.len = strlen(s.s);) , but I
do not see the purpose of the test model==NULL - pv_parse_format() return
either error, either 0 (success) with a valid model.

It cannot return with success but with a NULL model - or you found such a
case ?
checking the code of the function pv_parse_format():
     if(*el == NULL)
            return -1;
(see line 3804)

Regards,
Bogdan



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3535432&group_id=232389