[OpenSIPS-Devel] [ opensips-Patches-3535153 ] Correct types of a values in the usrloc module

[SourceForge.net]

Patches item #3535153, was opened at 2012-06-14 03:04
Message generated for change (Comment added) made by vladut-paiu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3535153&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Peter Lemenkov (peter_lemenkov)
Assigned to: Nobody/Anonymous (nobody)
Summary: Correct types of a values in the usrloc module

Initial Comment:
This patch fixes an issue with a erroneously set types during conversion within the usrloc module.

----------------------------------------------------------------------

>Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2012-07-03 03:02

Message:
Hello,

Looking at when the flags and cflags are loaded from DB to OpenSIPS mem,
they are fetched as DB_BITMAP, so it would probably be better to also save
them as DB_BITMAP to the db. 
Again, this was a small inconsistency, things were working until now since
the DB_INT and DB_BITMAP types are treated very similarly in the C code.

Patch was applied on OpenSIPS trunk

Thanks and Regards,
Vlad

----------------------------------------------------------------------

Comment By: Peter Lemenkov (peter_lemenkov)
Date: 2012-06-14 03:16

Message:
Honestly I'm not so sure about this patch. It's clear that vals2[3].type 
and vals2[4].type doe not match an actual val field used but maybe it's
better to change vals2[3].type  and vals2[4].type to DB_BITMAP type
instead.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3535153&group_id=232389