[OpenSIPS-Devel] [ opensips-Patches-3516387 ] B2B_LOGIC - transparent authentication

[SourceForge.net]

Patches item #3516387, was opened at 2012-04-10 03:35
Message generated for change (Comment added) made by nikbyte
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3516387&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Nobody/Anonymous (nobody)
Summary: B2B_LOGIC - transparent authentication

Initial Comment:
New option:
auth_mode = 0 - normal authentication
auth_mode = 1 - transparent authentication

Passes authentication from one to another side thorough b2b.


----------------------------------------------------------------------

>Comment By: Nick Altmann (nikbyte)
Date: 2012-04-20 12:22

Message:
Wow! I think flags in the first param is the best solution!

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-04-20 12:13

Message:
I agree with Ovidiu on both things - it should not be a global option and
it should be backward compatible.

The only options I see here is either use a kind of module variable to set
the flags before the init:
     $b2b_flags = xxxxxx ;
or as Nick suggested, with a function, to do more or less the same.

Another approach may be to quiz the flags in the first param, using a
separator - this will be backward compat. Like:
   b2b2_init_request("my_scenario","","");
->
   b2b2_init_request("my_scenario/flags","","");

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Nick Altmann (nikbyte)
Date: 2012-04-15 22:41

Message:
What do you think about new command, like b2b_set_flags("flags")?
I think that there are more than one option (flag) will be needed in
future.

Something like:
b2b_set_flags("T"); # transparent authentication
b2b_init_request("top hiding");

I think it would be better than just a variable.


----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2012-04-10 08:05

Message:
I would prefer a variable to be set.
Even if auth mode would be controlled as a parameter for b2b_init_request,
it must accept pvars and the work is pretty much there.  Also, inserting a
param in the middle of existing ones, will break forward compatibility (old
scripts will no longer work with new opensips versions).

----------------------------------------------------------------------

Comment By: Nick Altmann (nikbyte)
Date: 2012-04-10 07:51

Message:
What do you think about change b2b_init_request parameters?
First - scenario
Second - FLAGS (I think it will be useful in future)
Third-Sixth - scenario params

And make first flag to manage authentication mode?


----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2012-04-10 07:28

Message:
Controlling auth mode globally (via a module param) is a little bit
restrictive.
I would prefer having a variable the will will be set before initiating the
b2b call.  This will allow both authentication modes to coexist on the same
server.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3516387&group_id=232389