[OpenSIPS-Devel] [ opensips-Bugs-3514407 ] NATHELPER options pings doesn't pass sipmsg_validate()

[SourceForge.net]

Bugs item #3514407, was opened at 2012-04-02 22:41
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3514407&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.7.x
>Status: Closed
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Nick Altmann (nikbyte)
Assigned to: Razvan Crainea (razvancrainea)
Summary: NATHELPER options pings doesn't pass sipmsg_validate()

Initial Comment:
NATHELPER sip pings from opensips 1.7 doesn't pass sipmsg_validate() from opensips 1.8.

     SIP MESSAGE 1        192.168.0.2:5060() -> 192.168.0.1:5060()
      UDP Frame 2        3/Apr/12 09:33:11.6211 TimeFromPreviousSipFrame=4.7074 TimeFromStart=4.7074
 OPTIONS sip:192.168.0.1:5060 SIP/2.0
 Via: SIP/2.0/UDP 192.168.0.2:5060;branch=0
 Route: <sip:192.168.0.1;r2=on;lr;received=sip:8.8.8.8:49766>
 From: sip:pinger at opensips.org;tag=3a0b3605
 To: sip:192.168.0.1:5060
 Call-ID: f3bf68c2-22774093-63 at 192.168.0.2
 CSeq: 1 OPTIONS
 Content-Length: 0

In log:
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:parse_headers: flags=8000000
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:pv_get_useragent: no User-Agent header
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:parse_headers: flags=100
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:maxfwd:is_maxfwd_present: max_forwards header not found!
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:parse_headers: flags=ffffffffffffffff
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:sipmsgops:w_sip_validate:  doesn't have maxforwards header
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:sipmsgops:w_sip_validate: message does not comply with SIP RFC3261
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:pv_get_dsturi: no destination URI
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:pv_get_dsturi_attr: no destination URI
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:parse_headers: flags=8000000
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: DBG:core:pv_get_useragent: no User-Agent header
Apr  3 09:34:44 opensips /usr/sbin/opensips[9373]: [VALIDATE] SIP validate - the message is not RFC3261 compliant (M=OPTIONS IP=192.168.0.2:5060 RURI=sip:192.168.0.1:5060 DURI=<null> F=sip:pinger at opensips.org T=sip:192.168.0.1:5060 oP=udp pr=udp dP=<null> rP=udp ID=eda27986-a72bdfc3-81 at 192.168.0.2 cseq=1 UA=<null>)


----------------------------------------------------------------------

Comment By: Nick Altmann (nikbyte)
Date: 2012-04-03 03:11

Message:
All right. Thank you!

----------------------------------------------------------------------

Comment By: Razvan Crainea (razvancrainea)
Date: 2012-04-03 02:17

Message:
Hi, Nick!

I have just committed a fix on trunk, rev #8900. Can you please test and
let me know if it works properly?

Regards,
Răzvan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3514407&group_id=232389