[OpenSIPS-Devel] [ opensips-Bugs-3516488 ] b2b: CANCEL w/o Reason hdr

[SourceForge.net]

Bugs item #3516488, was opened at 2012-04-10 07:17
Message generated for change (Tracker Item Submitted) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3516488&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.8.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: b2b: CANCEL w/o Reason hdr

Initial Comment:
Rev 8875 changed the way transaction are cancelled.
Before, the b2b logic was able to push a Reason header down to tm to be appended to the CANCEL request.
The new way of sending CANCEL, doesn't allow setting extra headers in CANCEL requests:
http://opensips.svn.sourceforge.net/viewvc/opensips/trunk/modules/b2b_entities/dlg.c?r1=8875&r2=8874&pathrev=8875
line 1687

The tm is able to automatically add Reason header for cancelled transaction when a branch is answered, but for b2b. the transaction is not properly detected as being in "200" state.
When a call is forked in b2b mode and the answered, CANCEL requests are sent out to the other branches, but the Reason header is not set.
The reason for this is because in tm:build_cancel() the Trans->uas.status is still set to "180".

We have two issues here:
 1. the ability to push extra headers in CANCEL via tm api was lost;
 2. the tm uas transaction status is not properly set into a 200 state when a 200 ok is received on a branch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3516488&group_id=232389