[OpenSIPS-Devel] [ opensips-Patches-3411513 ] Consistently use rtpproxy switches

[SourceForge.net]

Patches item #3411513, was opened at 2011-09-19 18:17
Message generated for change (Comment added) made by razvancrainea
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3411513&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Peter Lemenkov (peter_lemenkov)
Assigned to: Nobody/Anonymous (nobody)
Summary: Consistently use rtpproxy switches

Initial Comment:
The flag for marking party  as being behind the symmetric proxy is 'S', not 'W' as it was implemented in nathelper. Moreover 'W' has also different meaning in rtpproxy protocol syntax.

Unfortunately this is obviously an incompatible change, however I think that elimination one source of confusing worth applying this,

----------------------------------------------------------------------

Comment By: Razvan Crainea (razvancrainea)
Date: 2011-09-21 11:32

Message:
Hi Peter,

Thank you for your patch. As you might know, the 'S' flag was used in the
nathelper module to swap between session creation and confirmation. This
flag became later deprecated, when rtpproxy_offer and rtpproxy_answer
functions were introduced.
We haven't changed the 'W' flag into 'S' yet for backward compatibility,
but we are considering it in the future.

Thanks again and regards,
Răzvan Crainea

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3411513&group_id=232389