[OpenSIPS-Devel] [ opensips-Bugs-3442873 ] problem with address add ...

[SourceForge.net]

Bugs item #3442873, was opened at 2011-11-26 08:23
Message generated for change (Comment added) made by razvancrainea
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3442873&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
Group: trunk
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Richard Revels (rrevels)
Assigned to: Razvan Crainea (razvancrainea)
Summary: problem with address add ...

Initial Comment:
Starting at line 1077 in opensipsctl is


                        CONTEXT_INFO=""
                        if [ ! -z "$6" ]; then
                                CONTEXT_INFO="$6"

                                QUERY="insert into $ADDRESS_TABLE \
                                        ($ADDRESS_GRP_COLUMN, $ADDRESS_IP_COLUMN, $ADDRESS_MASK_COLUMN, \
                                        $ADDRESS_PORT_COLUMN, $ADDRESS_PROTO_COLUMN, $ADDRESS_CONTEXT_INFO_COLUMN) \
                                        VALUES ('$1', '$2', '$3', '$4', '$5', CONTEXT_INFO);"

                                PATTERN=""
                                if [ ! -z "$7" ]; then
                                        PATTERN="$7"

                                        QUERY="insert into $ADDRESS_TABLE \
                                                ($ADDRESS_GRP_COLUMN, $ADDRESS_IP_COLUMN, $ADDRESS_MASK_COLUMN, \
                                                $ADDRESS_PORT_COLUMN, $ADDRESS_PROTO_COLUMN, $ADDRESS_CONTEXT_INFO_COLUMN, $ADDRESS_PATTERN_COLUMN) \
                                                VALUES ('$1', '$2', '$3', '$4', '$5', CONTEXT_INFO, PATTERN);"
                                fi
                        fi

Needs to have CONTEXT_INFO and PATTERN identified correctly and quoted in sql statements.


                        CONTEXT_INFO=""
                        if [ ! -z "$6" ]; then
                                CONTEXT_INFO="$6"

                                QUERY="insert into $ADDRESS_TABLE \
                                        ($ADDRESS_GRP_COLUMN, $ADDRESS_IP_COLUMN, $ADDRESS_MASK_COLUMN, \
                                        $ADDRESS_PORT_COLUMN, $ADDRESS_PROTO_COLUMN, $ADDRESS_CONTEXT_INFO_COLUMN) \
                                        VALUES ('$1', '$2', '$3', '$4', '$5', '$CONTEXT_INFO');"

                                PATTERN=""
                                if [ ! -z "$7" ]; then
                                        PATTERN="$7"

                                        QUERY="insert into $ADDRESS_TABLE \
                                                ($ADDRESS_GRP_COLUMN, $ADDRESS_IP_COLUMN, $ADDRESS_MASK_COLUMN, \
                                                $ADDRESS_PORT_COLUMN, $ADDRESS_PROTO_COLUMN, $ADDRESS_CONTEXT_INFO_COLUMN, $ADDRESS_PATTERN_COLUMN) \
                                                VALUES ('$1', '$2', '$3', '$4', '$5', '$CONTEXT_INFO', '$PATTERN');"
                                fi
                        fi


----------------------------------------------------------------------

>Comment By: Razvan Crainea (razvancrainea)
Date: 2011-11-29 05:35

Message:
Hi, Richard!

Thank you for reporting the bug and for the fix provided. I have committed
the fix on trunk, 1.6 and 1.7, along with the other fix you provided for
bug #3442146.

Best regards,
Răzvan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3442873&group_id=232389