[OpenSIPS-Devel] [ opensips-Bugs-3437624 ] ERR:handle_command: command syntax error

SourceForge.net noreply at sourceforge.net
Tue Nov 15 11:00:33 CET 2011


Bugs item #3437624, was opened at 2011-11-13 21:20
Message generated for change (Comment added) made by razvancrainea
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3437624&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.7.x
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Sergey Lavrov (sybasesql)
Assigned to: Razvan Crainea (razvancrainea)
Summary: ERR:handle_command: command syntax error

Initial Comment:
Dear All!

I have error in OpenSIPS when sending command to rtpproxy.
On rtpproxy side I got corrupted commands like that:
#1
DBUG:handle_command: received command "2235_263586 UR192.168.30.19<sip:Ddolotov at c34 Y2I3YmE5OTNmMjVjYWFhMDcxMTEzNmFkZTQ4ODIzNGQ. 89.237.60.130 40028 b468fe6b;2"
ERR:handle_command: unknown command modifier `<'
ERR:handle_command: unknown command modifier `p'
ERR:handle_command: unknown command modifier `:' 
ERR:handle_command: unknown command modifier `D'
ERR:handle_command: unknown command modifier `d'
ERR:handle_command: unknown command modifier `o'
ERR:handle_command: command syntax error
DBUG:doreply: sending reply "2235_263586 E1
#2
DBUG:handle_command: received command "2235_263588 UR192.168.30.99<sip:Ddolotoc34 YTg1NGEyOWIzMDQxZWZjMzUwY2IzNTc5MGFjNjU5ZWM. 89.237.60.130 40022 397c505c;2"
ERR:handle_command: unknown command modifier `<'
ERR:handle_command: unknown command modifier `p'
ERR:handle_command: unknown command modifier `:'
ERR:handle_command: unknown command modifier `D'
ERR:handle_command: unknown command modifier `d'
ERR:handle_command: unknown command modifier `o'
ERR:handle_command: command syntax error
DBUG:doreply: sending reply "2235_263588 E1

SIP trace for those two corrupted commands:
#1
SIP/2.0 183 Session Progress
Via: SIP/2.0/UDP 192.168.30.3;branch=z9hG4bK6458.5651f1e7.0
Via: SIP/2.0/UDP 192.168.1.33:1068;received=89.237.60.130;branch=z9hG4bK-d8754z-402a4a5ee523e074-1---d8754z-;rport=1068
Record-Route: <sip:73952727878 at 192.168.30.3;lr;r2=on;ftag=b468fe6b;nat=yes;did=215.4468b542>
Record-Route: <sip:73952727878 at 81.88.80.235;r2=on;lr;ftag=b468fe6b;nat=yes;did=215.4468b542>
Contact: <sip:73952727878 at 192.168.30.19:5066>
To: <sip:73952727878 at domain.com:5060>;tag=75cd306c
From: "olesya"<sip:olesya at domain.com:5060>;tag=b468fe6b
Call-ID: Y2I3YmE5OTNmMjVjYWFhMDcxMTEzNmFkZTQ4ODIzNGQ.
CSeq: 2 INVITE
Content-Type: application/sdp
User-Agent: Softswitch2
Content-Length: 216

v=0
o=- 1382957040 1382957040 IN IP4 192.168.11.22
s=-
c=IN IP4 192.168.11.22
t=0 0
m=audio 29506 RTP/AVP 8 101
c=IN IP4 192.168.11.22
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15

#2
SIP/2.0 183 Session Progress
Via: SIP/2.0/UDP 192.168.30.3;branch=z9hG4bK3644.b7fff0e7.0                                                                                                                                                                                 
Via: SIP/2.0/UDP 192.168.1.38:1229;received=89.237.60.130;branch=z9hG4bK-d8754z-7518c81feb727179-1---d8754z-;rport=1229
Record-Route: <sip:73852248471 at 192.168.30.3;lr;r2=on;ftag=397c505c;nat=yes;did=f24.1fbaccd6>
Record-Route: <sip:73852248471 at 81.88.80.235;r2=on;lr;ftag=397c505c;nat=yes;did=f24.1fbaccd6>
Contact: <sip:73852248471 at 192.168.30.9:5066>
To: <sip:73852248471 at domain.com:5060>;tag=c6df6443
From: "nadejda"<sip:nadejda at domain.com:5060>;tag=397c505c
Call-ID: YTg1NGEyOWIzMDQxZWZjMzUwY2IzNTc5MGFjNjU5ZWM.
CSeq: 2 INVITE
Content-Type: application/sdp
User-Agent: Softswitch2
Content-Length: 236

v=0
o=- 18446744071634906768 18446744071634906768 IN IP4 192.168.11.22
s=-
c=IN IP4 192.168.11.22
t=0 0
m=audio 25202 RTP/AVP 8 101
c=IN IP4 192.168.11.22
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15

----------------------------------------------------------------------

>Comment By: Razvan Crainea (razvancrainea)
Date: 2011-11-15 02:00

Message:
Hi Sergey,

Thank you for testing. I've also committed the fix on 1.7.

Regards,
Răzvan

----------------------------------------------------------------------

Comment By: Sergey Lavrov (sybasesql)
Date: 2011-11-14 22:08

Message:

Dear All!

I just installed opensips 1.7 revision 8547 with Walter's patch and it's
seems solve described problem.
Many errors that was yesterday disapear.
Thanks for your help!

----------------------------------------------------------------------

Comment By: Razvan Crainea (razvancrainea)
Date: 2011-11-14 02:26

Message:
Hi Sergey,

It is not a memory leak. As Walter noticed, the problem is that the buffer
contained an unallocated memory zone. I have fixed that on trunk, revision
8543. If you are using 1.7, please try to apply Walter's patch, recompile
and test again. 

@Walter: yes, I think the patch you provided solves this problem. Also, the
second observation is also true, but might only allocate more space than
needed. I also fixed that on trunk too.

Thank you both for the patch and the bug report!
Please let us know how your tests results.

Regards,
Răzvan

----------------------------------------------------------------------

Comment By: Walter Doekes (wdoekes)
Date: 2011-11-14 01:04

Message:
I could be wrong, but this doesn't look right:

http://wjd.nu/files/2011/11/os17x-3437624-bad_iov_len.patch?view

Although I'm not sure it would be the cause for your problem.

(@bogdan: and the if (op->s.len <= op->oidx + s->len)  in append_opts_str
should be a '<', but that causes no harm)

----------------------------------------------------------------------

Comment By: Sergey Lavrov (sybasesql)
Date: 2011-11-13 21:28

Message:
And it's seems memory leak, because I have part of comamnd that OpenSIPS
send to rtpproxy in SUBSCRIBE message from other client, e.g. Ddolotov.

SUBSCRIBE sip:Ddolotov at samedia.mangosip.ru;transport=UDP SIP/2.0
Via: SIP/2.0/UDP
10.8.0.64:5060;branch=z9hG4bK-d8754z-8e908845762d42ec-1---d8754z-
Max-Forwards: 70
Contact: <sip:Ddolotov at 10.8.0.64:5060>
To: "Ddolotov"<sip:Ddolotov at domain.com;transport=UDP>
From: "Ddolotov"<sip:Ddolotov at domain.com;transport=UDP>;tag=b02a8b51
Call-ID: Y2M4MGE2ZTBkMjk4MTcxNGIyZjYyNmYxMzAwYjc2OTM.
CSeq: 1 SUBSCRIBE
Expires: 3600
Accept: application/simple-message-summary
Allow: INVITE, ACK, CANCEL, BYE, NOTIFY, REFER, MESSAGE, OPTIONS, INFO,
SUBSCRIBE
Supported: replaces, norefersub, extended-refer, X-cisco-serviceuri
User-Agent: Zoiper rev.9332
Event: message-summary
Allow-Events: presence, kpml
Content-Length: 0

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3437624&group_id=232389



More information about the Devel mailing list