[OpenSIPS-Devel] [ opensips-Patches-3047314 ] base64, sip_uri ob param, msg_cb fix

[SourceForge.net]

Patches item #3047314, was opened at 2010-08-18 01:02
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3047314&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: trunk
Status: Open
>Resolution: Invalid
>Priority: 2
Private: No
Submitted By: Kennard White (kennardwhite)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: base64, sip_uri ob param, msg_cb fix

Initial Comment:
Two de-coupled changes (sorry):
1. Add functions for base64 encoding and decoding. Encoder was previously in presence module.
2. Add 'ob' parameter support to sip_uri struct and parser. Used by RFC5626 'outbound' support.

Let me know if any issues.
Thanks,
Kennard

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2011-06-30 14:42

Message:
Hi Kennard,

Going through the patches :
   - the msg_cb errors are fixed on SVN - thank you 
   - the "ob" URI param  - there is no need for it right now, as all URI
params are stored into an generic param array
   - regarding the BASE64 function - what is the reason for adding them
into core ? I see presence is still using its own function, so basically
there is no one using the BASE64 core functions.

Best regards,
Bogdan

----------------------------------------------------------------------

Comment By: Maksym Sobolyev (sobomax)
Date: 2010-12-06 23:17

Message:
Kennard, I've checked part of this patch to address uninitialized msg_cb
pointer. Please check revision 7466 and 7467 and let me know if you still
have this issue.

-Maxim

----------------------------------------------------------------------

Comment By: Kennard White (kennardwhite)
Date: 2010-08-21 00:06

Message:
When using this, found two pre-existing bugs that are addressed in 2nd
patch file:
A. tm doesn't zero the sip_msg->msg_cb field when cloning into shm mem. It
leaves the pkg mem pointer in place. Later on (in failure route processing)
this value is used in different process and get segfault.
B. the linked-list handling for msg_cb was broken, and wouldn't handle
more than 2 callbacks.

Fix added to this patch upload because it also includes tm cloning the new
sip_uri ob param.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3047314&group_id=232389