[OpenSIPS-Devel] [PATCH 1/1] Check for stale nonce in pre_auth

[Peter Lemenkov]

Check for stale nonce in pre_auth, before actual auth request. It decreases
dramatically the number of requests to the actual auth backend thus improving
performance greatly. Take a look at the following plot where the results of
this patch can be seen clearly:

http://twitpic.com/3k66ri

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
 modules/auth/api.c |   35 ++++++++++++++++++-----------------
 1 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/modules/auth/api.c b/modules/auth/api.c
index f076e85..ea54f20 100644
--- a/modules/auth/api.c
+++ b/modules/auth/api.c
@@ -215,6 +215,12 @@ auth_result_t pre_auth(struct sip_msg* _m, str* _realm, hdr_types_t _hftype,
 		return ERROR;
 	}
 
+	if (is_nonce_stale(&c->digest.nonce)) {
+		LM_DBG("stale nonce value received\n");
+		c->stale = 1;
+		return STALE_NONCE;
+	}
+
 	if (check_nonce(&c->digest.nonce, &secret) != 0) {
 		LM_DBG("invalid nonce value received\n");
 		c->stale = 1;
@@ -240,27 +246,22 @@ auth_result_t post_auth(struct sip_msg* _m, struct hdr_field* _h)
 		(_m->REQ_METHOD == METHOD_CANCEL)) 
 		return AUTHORIZED;
 
-	if (is_nonce_stale(&c->digest.nonce)) {
-			LM_DBG("response is OK, but nonce is stale\n");
+	if(!disable_nonce_check) {
+		/* Verify if it is the first time this nonce is received */
+		index= get_nonce_index(&c->digest.nonce);
+		if(index== -1) {
+			LM_ERR("failed to extract nonce index\n");
+			return ERROR;
+		}
+		LM_DBG("nonce index= %d\n", index);
+
+		if(!is_nonce_index_valid(index)) {
+			LM_DBG("nonce index not valid\n");
 			c->stale = 1;
 			return STALE_NONCE;
-	} else {
-		if(!disable_nonce_check) {
-			/* Verify if it is the first time this nonce is received */
-			index= get_nonce_index(&c->digest.nonce);
-			if(index== -1) {
-				LM_ERR("failed to extract nonce index\n");
-				return ERROR;
-			}
-			LM_DBG("nonce index= %d\n", index);
-
-			if(!is_nonce_index_valid(index)) {
-				LM_DBG("nonce index not valid\n");
-				c->stale = 1;
-				return STALE_NONCE;
-			}
 		}
 	}
+
 	return AUTHORIZED;
 
 }
-- 
1.7.6