[OpenSIPS-Devel] [ opensips-Patches-3193565 ] Call Control does not properly handle custom init/start/stop

[SourceForge.net]

Patches item #3193565, was opened at 2011-02-26 17:27
Message generated for change (Settings changed) made by dpacket
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3193565&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dynamic Packet (dpacket)
>Assigned to: Dan (dan_pascu)
Summary: Call Control does not properly handle custom init/start/stop

Initial Comment:
When using custom init/start/stop messages, no command word or default params are sent over. This results in loosing part of the call information which is unavailable to the AVP set, such as dialogid. 

 Also the issue for the format, for default messages, a certain format is used, custom, completely different. It seems like these custom messages were overlooked in the original code perhaps because no one used them. Attached is the patch that corrects this behavior. Custom AVP's should be IN ADDITION to the standard message AND in the SAME FORMAT, without loosing dialogid. 

Below is an example of a default start message and then a custom one before the patch.

Default START MESSAGE example:
start
callid: 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt
dialogid: 3838:1383587848

Custom START MESSAGE example (BEFORE PATCH):
from = sip:test5 at sip.domain.com to = sip:18885233456 at sip.domain.com callid = 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt 

Custom START MESSAGE example (AFTER PATCH):
start
callid: 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt
dialogid: 3838:1383587848
from: sip:test5 at sip.domain.com 
to: sip:18885233456 at sip.domain.com


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3193565&group_id=232389