[OpenSIPS-Devel] [ opensips-Patches-3400375 ] Partial solution to leaky fixups in Perl module

[SourceForge.net]

Patches item #3400375, was opened at 2011-08-29 14:34
Message generated for change (Tracker Item Submitted) made by rkosai-marchex
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3400375&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ryan K (rkosai-marchex)
Assigned to: Nobody/Anonymous (nobody)
Summary: Partial solution to leaky fixups in Perl module

Initial Comment:
The attached patch addresses some of the memory leaks in the perl module when using unsafe module functions.

The advantage is that it fixes leaks in some of the more commonly used functions (sl_send_reply, insert_hf, remove_hf, t_reply).  The disadvantage is that it doesn't fix all of the leaks in all of the module functions, which gives people a slightly false sense of security.  However, if people are using the unsafemodfnc parameter, presumably they understand some of the risks.  It should be pretty easy to extend this solution, so anyone who wants to make their own modifications on a local build can fix memory leaks in the future.

I've been using a similar patch in production use, on hundreds of thousands of calls per day, and it seems to work well for my particular case, so I'm submitting it upstream for consideration.  On the other hand, the solution is something of a hack.  I totally understand not wanting to accept a patch that doesn't provide a general case solution.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3400375&group_id=232389