[OpenSIPS-Devel] [ opensips-Bugs-3071294 ] dlg_end_dlg produces cut BYE if called with extra headers

[SourceForge.net]

Bugs item #3071294, was opened at 2010-09-19 17:18
Message generated for change (Comment added) made by cupotka2008
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3071294&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Alex Massover (cupotka2008)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: dlg_end_dlg produces cut BYE if called with extra headers

Initial Comment:
Hi,

I noticed that in trunk version dlg_dlg_dlg from dialog module produces corrupted (cut) BYE requests if called with extra headers. Final \r\n is missing in the BYE request.

Here's example of fifo command I use:
opensipsctl fifo dlg_end_dlg 35211 1239562180 "Reason: aa\r\n\r\n"

Which results in the BYE message ending with "..Reason:aa..", i.e. final \r\n is missing.

----------------------------------------------------------------------

>Comment By: Alex Massover (cupotka2008)
Date: 2010-09-21 11:06

Message:
Hi, 
Yes,
If I use UDP MI it works... So yes, the problem is either in shell or
opensipsctl script or in MI FIFO.

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-09-21 10:12

Message:
That is perfectly correct - As the extra hdr you pass must be complete
headers (with end-of-hdr CRLF also), what you see there is your headers +
end of all headers (which is correctly added by dialog module)

So, the test shows that the \r\n from cli are lost (bash eaten?) and not
passed to actual MI command...

----------------------------------------------------------------------

Comment By: Alex Massover (cupotka2008)
Date: 2010-09-21 09:47

Message:
opensipsctl fifo dlg_end_dlg 43244 21036759 "Reason: aa1234"

produces:

0170  3a 20 37 30 0d 0a 52 65 61 73 6f 6e 3a 20 61 61   : 70..Reason: aa
0180  31 32 33 34 0d 0a                                 1234..

Packet ends with 0d 0a and not with 0d 0a 0d 0a

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-09-21 09:16

Message:
Hi Alex - are you sure the \r\n chars are not lost by shell ? try something
like;
    opensipsctl fifo dlg_end_dlg 35211 1239562180 "Reason: aa1234"

to see if all the chars are copied into the message (even if the header
will be corrupted - just a POC).

Regards,
Bogdan


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3071294&group_id=232389