[OpenSIPS-Devel] very minor bug in opensips tm fwd

[Bogdan-Andrei Iancu]

Hi Kennard,

Thanks for the fix - is it on SVN.

Best regards,
Bogdan

Kennard_White at logitech.com wrote:
>
> Hi,
>
> I believe there is a minor bug in opensips HEAD in the tm module 
> t_fwd.c. The function update_uac_dst sets ser_error to one of two 
> options: E_OUT_OF_MEM or E_NO_SOCKET. This is overwritten by add_uac. 
> The simple one line fix is:
>
> --- a/modules/tm/t_fwd.c
> +++ b/modules/tm/t_fwd.c
> @@ -430,7 +430,7 @@ static int add_uac( struct cell *t, struct sip_msg 
> *request, str *uri,
> t->uac[branch].request.dst.proto = proxy->proto;
>
> if ( update_uac_dst( request, &t->uac[branch] )!=0) {
> - ret = E_OUT_OF_MEM;
> + ret = ser_error;
> goto error02;
> }
>
> A more elaborate fix might be to not set ser_error at all in 
> update_uac_dst and just return the error code.
>
> Note that this error condition occurs when a REGISTER Path header has 
> bogus (unreachable) URI. Unfortunately this is all too easy to do, and 
> having a useful error message is helpful.
>
> Regards,
> Kennard
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>   


-- 
Bogdan-Andrei Iancu
OpenSIPS Bootcamp
20 - 24 September 2010, Frankfurt, Germany
www.voice-system.ro