[OpenSIPS-Devel] [ opensips-Bugs-3138595 ] Bad comparaison in B2B_Entities

[SourceForge.net]

Bugs item #3138595, was opened at 2010-12-16 16:43
Message generated for change (Settings changed) made by vladut-paiu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3138595&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.6.x
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Vladut-Stefan Paiu (vladut-paiu)
Summary: Bad comparaison in B2B_Entities

Initial Comment:
HI,

In function b2bl_search_iteratively, if tag and callid match, you compare ruri if it is not NULL.
But this comparaison is false, if first RURI is user at x.x.x.x and the next one is user at x.x.x.x:5060;transport=UDP, the test is false
but RURI are the same.

Regards,

----------------------------------------------------------------------

Comment By: Vladut-Stefan Paiu (vladut-paiu)
Date: 2010-12-16 18:13

Message:
Hello,

RFC 3261 states that :
"A URI omitting any component with a default value will not 
match a URI explicitly containing that component with its
default value.  For instance, a URI omitting the optional port
component will not match a URI explicitly declaring port 5060.
The same is true for the transport-parameter, ttl-parameter,
user-parameter, and method components.

Defining sip:user at host to not be equivalent to
sip:user at host:5060 is a change from RFC 2543. "

Still, the check isn't 100 % accurate, as it doesn't take into account the
fact the ordering of sip URI parameters isn't significant. This will be
solved in a couple of days.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3138595&group_id=232389