[OpenSIPS-Devel] [ opensips-Bugs-3132296 ] rtpproxy_offer("L") returns wrong port on re-invite

[SourceForge.net]

Bugs item #3132296, was opened at 2010-12-08 15:26
Message generated for change (Comment added) made by bukinr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3132296&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ruslan Bukin (bukinr)
Assigned to: Nobody/Anonymous (nobody)
Summary: rtpproxy_offer("L") returns wrong port on re-invite

Initial Comment:
I call rtpproxy_offer("fr") on invite request and rtpproxy_answer("fr") on invite reply. Request and reply comes with sdp and client rtp media successfully served by rtpproxy.

In loose_route section I call rtpproxy_offer with force-lookup flag ("Lfr")  which returns status 0 on re-invite, but returns wrong rtpproxy port!
(re-invites sent by sippy b2bua in case of keep-alives).

I have switched tags like below. I am sure it is not correct coding, but it resolved my problem, at least for a request.

--- opensips-trunk/modules/nathelper/nathelper.c   (revision 7462)
+++ opensips-trunk/modules/nathelper/nathelper.c   (working copy)
@@ -3315,6 +3315,13 @@
   	   	    FORCE_RTP_PROXY_RET (-1);
 		    			}
						create = 0;
+
+		if (msg->first_line.type==SIP_REQUEST && args->offer!=0) {
+		   				      tmp = from_tag;
+						      	    from_tag = to_tag;
+							    	       to_tag = tmp;
+								       	      }
+
	} else if ((msg->first_line.type==SIP_REPLY && args->offer!=0)||
 	(msg->first_line.type == SIP_REQUEST && args->offer == 0) ) {
 			      if (to_tag.len == 0) {


----------------------------------------------------------------------

Comment By: Ruslan Bukin (bukinr)
Date: 2010-12-08 17:40

Message:
I am following this commit message:

http://lists.iptel.org/pipermail/serdev/2007-December/011450.html

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-12-08 17:13

Message:
why do you use the L flag in rtpproxy_offer() ? L "lookup" is specific for
reply processing....

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3132296&group_id=232389