[OpenSIPS-Devel] [ opensips-Patches-3019749 ] nathelper: rtpproxy_answer() handles ACK w/SDP incorrectly

[SourceForge.net]

Patches item #3019749, was opened at 2010-06-22 20:54
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3019749&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.5.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: John Riordan (john_riordan)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: nathelper: rtpproxy_answer() handles ACK w/SDP incorrectly

Initial Comment:
When rewriting the SDP of an ACK rtpproxy_answer() retrieves the wrong port from rtpproxy. 

This is reproducible by handling SDP offered in a 200 Ok response with rtpproxy_offer() and then processing the answering SDP in an ACK with rtpproxy_answer() - the result is that the same port gets written into the ACK's SDP as was written into the Ok's SDP. In short, the 200 Ok is being handled correctly when it contain an SDP offer since the to/from tag are swapped inside force_rtp_proxy() before getting passed along to rtpproxy. The swap is critical as it provides consistent results when processing SDP offered in INVITE requests and Ok responses during re-invites within the same dialog. But the complimentary swapping is not being done for SDP answers contained in ACKs.


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-08-01 23:40

Message:
Hi John,

Fix uploaded.

Thanks & Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3019749&group_id=232389